Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9812036: Revert 128089 - Initial extension bindings for Media Gallery API. (Closed)

Created:
8 years, 9 months ago by greggman
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 128089 - Initial extension bindings for Media Gallery API. BUG=NONE TEST=NONE Review URL: https://chromiumcodereview.appspot.com/9358076 TBR=vandebo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128136

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -371 lines) Patch
D chrome/browser/extensions/api/media_gallery/media_gallery_api.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/extensions/api/media_gallery/media_gallery_api.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/extensions/api/media_gallery/media_gallery_apitest.cc View 1 chunk +0 lines, -23 lines 0 comments Download
MM chrome/browser/extensions/extension_function_registry.cc View 2 chunks +0 lines, -7 lines 0 comments Download
MM chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
MM chrome/chrome_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
MM chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/common/common_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/api/experimental.mediaGalleries.json View 1 chunk +0 lines, -98 lines 0 comments Download
MM chrome/common/extensions/api/extension_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/common/extensions/docs/js/api_page_generator.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.cc View 4 chunks +0 lines, -6 lines 0 comments Download
D chrome/renderer/extensions/media_gallery_custom_bindings.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/renderer/extensions/media_gallery_custom_bindings.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M chrome/renderer/renderer_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/renderer/resources/extensions/experimental.media_galleries_custom_bindings.js View 1 chunk +0 lines, -29 lines 0 comments Download
MM chrome/test/data/extensions/api_test/README.txt View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/media_gallery/manifest.json View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/extensions/api_test/media_gallery/test.js View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
greggman
8 years, 9 months ago (2012-03-22 01:42:19 UTC) #1
vandebo (ex-Chrome)
8 years, 9 months ago (2012-03-22 02:34:35 UTC) #2 
LGTM - thanks for the revert.  This CL has been racing changes in the extension
code for days, I'd guess something changed between the last try and the commit.

Powered by Google App Engine
This is Rietveld 408576698