Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 9812035: Introduce CertVerifierProc to handle system cert validation. (Closed)

Created:
8 years, 9 months ago by Ryan Sleevi
Modified:
8 years, 9 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Introduce a CertVerifierProc to handle system cert validation. In preparation for moving certificate path building and verification out of X509Certificate, introduce a CertVerifierProc that can be used by the MultiThreadedCertVerifier to verify certificates using the underlying system store. Unit tests previously coded against X509Certificate are now coded against the CertVerifierProc, as future CLs will shift verification into this interface. This was originally reviewed as http://codereview.chromium.org/9584041/ and http://codereview.chromium.org/9553014/ , and has been combined in order to preserve SVN history. BUG=114343 TEST=net_unittests R=wtc Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128150

Patch Set 1 #

Patch Set 2 : Actually add the stub. Curse you SVN #

Patch Set 3 : Lint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -2155 lines) Patch
M net/base/cert_database_nss_unittest.cc View 4 chunks +9 lines, -4 lines 0 comments Download
A net/base/cert_verify_proc.h View 1 1 chunk +74 lines, -0 lines 0 comments Download
A net/base/cert_verify_proc.cc View 1 1 chunk +47 lines, -0 lines 0 comments Download
A + net/base/cert_verify_proc_unittest.cc View 1 2 42 chunks +84 lines, -1150 lines 0 comments Download
M net/base/multi_threaded_cert_verifier.h View 5 chunks +7 lines, -1 line 0 comments Download
M net/base/multi_threaded_cert_verifier.cc View 1 2 8 chunks +18 lines, -5 lines 0 comments Download
M net/base/multi_threaded_cert_verifier_unittest.cc View 9 chunks +83 lines, -56 lines 0 comments Download
M net/base/single_request_cert_verifier.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/base/test_certificate_data.h View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M net/base/transport_security_state_unittest.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M net/base/x509_certificate.h View 3 chunks +31 lines, -30 lines 0 comments Download
M net/base/x509_certificate_unittest.cc View 12 chunks +1 line, -902 lines 0 comments Download
M net/net.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ryan Sleevi
wtc: TBR; you already reviewed these - this just copies the patches into my svn ...
8 years, 9 months ago (2012-03-22 01:16:31 UTC) #1
wtc
8 years, 9 months ago (2012-03-22 01:43:47 UTC) #2
LGTM.

Please add R=...,BUG=114343,TEST=... to the CL's description.

In the CL's description, it would be nice to name the helper
class and stub class rather than using the vague terms.

Powered by Google App Engine
This is Rietveld 408576698