Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7212)

Unified Diff: chrome/test/data/extensions/api_test/keybinding/basics/manifest.json

Issue 9812008: Polish the keybinding implementation a bit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/keybinding/basics/manifest.json
===================================================================
--- chrome/test/data/extensions/api_test/keybinding/basics/manifest.json (revision 129600)
+++ chrome/test/data/extensions/api_test/keybinding/basics/manifest.json (working copy)
@@ -14,12 +14,20 @@
},
"commands": {
"toggle-feature": {
- "key": " Ctrl - Shift - Y ",
+ "suggested_key": {
+ "windows": "Ctrl+Shift+Y",
+ "mac": "Command+Shift+Y",
+ "linux": "Ctrl+Shift+Y",
+ "chromeos": "Ctrl+Shift+Y",
+ "default": "Ctrl+Shift+Y"
+ },
"description": "Toggle feature foo"
},
- "browserAction": {
- "key": "Ctrl+Shift+F",
- "description": ""
+ "_execute_browser_action": {
+ "suggested_key": {
+ "mac": "Command+Shift+F",
+ "default": "Ctrl+Shift+F"
+ }
}
}
}

Powered by Google App Engine
This is Rietveld 408576698