Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Side by Side Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 981143006: Metrics provider for statistical stack profiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: address comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/chrome_metrics_service_client.h" 5 #include "chrome/browser/metrics/chrome_metrics_service_client.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "base/files/file_path.h" 12 #include "base/files/file_path.h"
13 #include "base/logging.h" 13 #include "base/logging.h"
14 #include "base/metrics/histogram.h" 14 #include "base/metrics/histogram.h"
15 #include "base/prefs/pref_registry_simple.h" 15 #include "base/prefs/pref_registry_simple.h"
16 #include "base/prefs/pref_service.h" 16 #include "base/prefs/pref_service.h"
17 #include "base/strings/string16.h" 17 #include "base/strings/string16.h"
18 #include "base/strings/string_util.h" 18 #include "base/strings/string_util.h"
19 #include "base/strings/utf_string_conversions.h" 19 #include "base/strings/utf_string_conversions.h"
20 #include "base/threading/platform_thread.h" 20 #include "base/threading/platform_thread.h"
21 #include "chrome/browser/browser_process.h" 21 #include "chrome/browser/browser_process.h"
22 #include "chrome/browser/chrome_notification_types.h" 22 #include "chrome/browser/chrome_notification_types.h"
23 #include "chrome/browser/google/google_brand.h" 23 #include "chrome/browser/google/google_brand.h"
24 #include "chrome/browser/metrics/call_stack_profile_metrics_provider.h"
24 #include "chrome/browser/metrics/chrome_stability_metrics_provider.h" 25 #include "chrome/browser/metrics/chrome_stability_metrics_provider.h"
25 #include "chrome/browser/metrics/omnibox_metrics_provider.h" 26 #include "chrome/browser/metrics/omnibox_metrics_provider.h"
26 #include "chrome/browser/ui/browser_otr_state.h" 27 #include "chrome/browser/ui/browser_otr_state.h"
27 #include "chrome/common/chrome_constants.h" 28 #include "chrome/common/chrome_constants.h"
28 #include "chrome/common/chrome_switches.h" 29 #include "chrome/common/chrome_switches.h"
29 #include "chrome/common/chrome_version_info.h" 30 #include "chrome/common/chrome_version_info.h"
30 #include "chrome/common/crash_keys.h" 31 #include "chrome/common/crash_keys.h"
31 #include "chrome/common/pref_names.h" 32 #include "chrome/common/pref_names.h"
32 #include "chrome/common/render_messages.h" 33 #include "chrome/common/render_messages.h"
33 #include "components/metrics/gpu/gpu_metrics_provider.h" 34 #include "components/metrics/gpu/gpu_metrics_provider.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 } 97 }
97 NOTREACHED(); 98 NOTREACHED();
98 return metrics::SystemProfileProto::CHANNEL_UNKNOWN; 99 return metrics::SystemProfileProto::CHANNEL_UNKNOWN;
99 } 100 }
100 101
101 } // namespace 102 } // namespace
102 103
103 ChromeMetricsServiceClient::ChromeMetricsServiceClient( 104 ChromeMetricsServiceClient::ChromeMetricsServiceClient(
104 metrics::MetricsStateManager* state_manager) 105 metrics::MetricsStateManager* state_manager)
105 : metrics_state_manager_(state_manager), 106 : metrics_state_manager_(state_manager),
106 chromeos_metrics_provider_(NULL), 107 chromeos_metrics_provider_(nullptr),
107 waiting_for_collect_final_metrics_step_(false), 108 waiting_for_collect_final_metrics_step_(false),
108 num_async_histogram_fetches_in_progress_(0), 109 num_async_histogram_fetches_in_progress_(0),
110 profiler_metrics_provider_(nullptr),
111 #if defined(ENABLE_PLUGINS)
Alexei Svitkine (slow) 2015/03/17 23:10:10 FYI: If https://codereview.chromium.org/999623002/
Mike Wittman 2015/03/18 01:48:36 Thanks for the heads up.
112 plugin_metrics_provider_(nullptr),
113 #endif
114 #if defined(OS_WIN)
115 google_update_metrics_provider_(nullptr),
116 #endif
109 weak_ptr_factory_(this) { 117 weak_ptr_factory_(this) {
110 DCHECK(thread_checker_.CalledOnValidThread()); 118 DCHECK(thread_checker_.CalledOnValidThread());
111 RecordCommandLineMetrics(); 119 RecordCommandLineMetrics();
112 RegisterForNotifications(); 120 RegisterForNotifications();
113 121
114 #if defined(OS_WIN) 122 #if defined(OS_WIN)
115 CountBrowserCrashDumpAttempts(); 123 CountBrowserCrashDumpAttempts();
116 #endif // defined(OS_WIN) 124 #endif // defined(OS_WIN)
117 } 125 }
118 126
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 metrics_service_->RegisterMetricsProvider( 294 metrics_service_->RegisterMetricsProvider(
287 scoped_ptr<metrics::MetricsProvider>(new ChromeStabilityMetricsProvider)); 295 scoped_ptr<metrics::MetricsProvider>(new ChromeStabilityMetricsProvider));
288 metrics_service_->RegisterMetricsProvider( 296 metrics_service_->RegisterMetricsProvider(
289 scoped_ptr<metrics::MetricsProvider>(new metrics::GPUMetricsProvider())); 297 scoped_ptr<metrics::MetricsProvider>(new metrics::GPUMetricsProvider()));
290 298
291 profiler_metrics_provider_ = 299 profiler_metrics_provider_ =
292 new metrics::ProfilerMetricsProvider(cellular_callback); 300 new metrics::ProfilerMetricsProvider(cellular_callback);
293 metrics_service_->RegisterMetricsProvider( 301 metrics_service_->RegisterMetricsProvider(
294 scoped_ptr<metrics::MetricsProvider>(profiler_metrics_provider_)); 302 scoped_ptr<metrics::MetricsProvider>(profiler_metrics_provider_));
295 303
304 metrics_service_->RegisterMetricsProvider(
305 scoped_ptr<metrics::MetricsProvider>(
306 new CallStackProfileMetricsProvider));
307
296 #if defined(OS_ANDROID) 308 #if defined(OS_ANDROID)
297 metrics_service_->RegisterMetricsProvider( 309 metrics_service_->RegisterMetricsProvider(
298 scoped_ptr<metrics::MetricsProvider>( 310 scoped_ptr<metrics::MetricsProvider>(
299 new AndroidMetricsProvider(g_browser_process->local_state()))); 311 new AndroidMetricsProvider(g_browser_process->local_state())));
300 #endif // defined(OS_ANDROID) 312 #endif // defined(OS_ANDROID)
301 313
302 #if defined(OS_WIN) 314 #if defined(OS_WIN)
303 google_update_metrics_provider_ = new GoogleUpdateMetricsProviderWin; 315 google_update_metrics_provider_ = new GoogleUpdateMetricsProviderWin;
304 metrics_service_->RegisterMetricsProvider( 316 metrics_service_->RegisterMetricsProvider(
305 scoped_ptr<metrics::MetricsProvider>(google_update_metrics_provider_)); 317 scoped_ptr<metrics::MetricsProvider>(google_update_metrics_provider_));
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 // Capture the histogram samples. 565 // Capture the histogram samples.
554 if (dumps_with_crash != 0) 566 if (dumps_with_crash != 0)
555 UMA_HISTOGRAM_COUNTS("Chrome.BrowserDumpsWithCrash", dumps_with_crash); 567 UMA_HISTOGRAM_COUNTS("Chrome.BrowserDumpsWithCrash", dumps_with_crash);
556 if (dumps_with_no_crash != 0) 568 if (dumps_with_no_crash != 0)
557 UMA_HISTOGRAM_COUNTS("Chrome.BrowserDumpsWithNoCrash", dumps_with_no_crash); 569 UMA_HISTOGRAM_COUNTS("Chrome.BrowserDumpsWithNoCrash", dumps_with_no_crash);
558 int total_dumps = dumps_with_crash + dumps_with_no_crash; 570 int total_dumps = dumps_with_crash + dumps_with_no_crash;
559 if (total_dumps != 0) 571 if (total_dumps != 0)
560 UMA_HISTOGRAM_COUNTS("Chrome.BrowserCrashDumpAttempts", total_dumps); 572 UMA_HISTOGRAM_COUNTS("Chrome.BrowserCrashDumpAttempts", total_dumps);
561 } 573 }
562 #endif // defined(OS_WIN) 574 #endif // defined(OS_WIN)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698