Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: chrome/browser/ui/search_engines/edit_search_engine_controller.cc

Issue 9811022: Misc. small cleanups to minimize TemplateURL refactoring diffs: (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search_engines/edit_search_engine_controller.cc
===================================================================
--- chrome/browser/ui/search_engines/edit_search_engine_controller.cc (revision 128075)
+++ chrome/browser/ui/search_engines/edit_search_engine_controller.cc (working copy)
@@ -49,9 +49,8 @@
GetDefaultSearchProvider()))
return false;
- // If the url has a search term, replace it with a random string and make
- // sure the resulting URL is valid. We don't check the validity of the url
- // with the search term as that is not necessarily valid.
+ // Replace any search term with a placeholder string and make sure the
+ // resulting URL is valid.
return GURL(template_ref.ReplaceSearchTerms(TemplateURL(), ASCIIToUTF16("x"),
TemplateURLRef::NO_SUGGESTIONS_AVAILABLE, string16())).is_valid();
}

Powered by Google App Engine
This is Rietveld 408576698