Ignore Content-Length mismatches when Content-Length is too large.

net/http/http_network_transaction_spdy21_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_network_transaction.h"
 
 #include <math.h>  // ceil
 #include <stdarg.h>
 #include <string>
 #include <vector>
@@ skipping 6147 matching lines @@
   EXPECT_EQ(OK, callback.WaitForResult());
 
   const HttpResponseInfo* response = trans->GetResponseInfo();
   ASSERT_TRUE(response != NULL);
 
   EXPECT_TRUE(response->headers != NULL);
   EXPECT_EQ("HTTP/1.0 200 OK", response->headers->GetStatusLine());
 
   std::string response_data;
   rv = ReadTransaction(trans.get(), &response_data);
-  EXPECT_EQ(ERR_CONNECTION_CLOSED, rv);
+  EXPECT_EQ(OK, rv);

[rvargas (doing something else), 2012/03/24 01:06:50]

This is an interesting case. SPDY is really at a different layer, so it makes
sense that it should not care about any content-length mismatch... however,
there are some security implications with content-length mismatches in SSL
connections... and it sort of makes sense to be able to spec SPDY to enforce
something here.

In other words, seems OK to land this as is, but explore if we should do
something about it at least for SPDY (being a new implementation for everyone).

[cbentzel, 2012/03/24 01:24:35]

Yes, this is interesting. I am concerned about web compatibility issues with
SPDY proxies forwarding data along from incorrect HTTP backends - in that case
we may want this behavior to be permitted.

 }
 
 TEST_F(HttpNetworkTransactionSpdy21Test, UploadFileSmallerThanLength) {
   HttpRequestInfo request;
   request.method = "POST";
   request.url = GURL("http://www.google.com/upload");
   request.upload_data = new UploadData;
   request.load_flags = 0;
 
   SessionDependencies session_deps;
@@ skipping 3373 matching lines @@
   HttpStreamFactory::SetNextProtos(std::vector<std::string>());
   ClientSocketPoolManager::set_max_sockets_per_pool(
       HttpNetworkSession::NORMAL_SOCKET_POOL, old_max_sockets_per_pool);
   ClientSocketPoolManager::set_max_sockets_per_proxy_server(
       HttpNetworkSession::NORMAL_SOCKET_POOL, old_max_sockets_per_proxy_server);
   ClientSocketPoolManager::set_max_sockets_per_group(
       HttpNetworkSession::NORMAL_SOCKET_POOL, old_max_sockets_per_group);
 }
 
 }  // namespace net