Issue 9810023: Prioritize smaller favicons over larger ones for tabs, etc. (Take 3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9810023: Prioritize smaller favicons over larger ones for tabs, etc. (Take 3) (Closed)

Created:
8 years, 9 months ago by stevenjb

Modified:
8 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Prioritize smaller favicons over larger ones for tabs, etc. (Take 3) Original CL: http://codereview.chromium.org/9696057 BUG=110143, 119233 TEST=Test favicon behavior thoroughly. On Ash with the latest GTalk, avatar icons should show in the launcher and status icons should show in the title bar. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128083

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+287 lines, -127 lines)			Patch
M	chrome/browser/favicon/favicon_handler.h	View		9 chunks	+42 lines, -18 lines	0 comments	Download
M	chrome/browser/favicon/favicon_handler.cc	View	1	8 chunks	+98 lines, -25 lines	0 comments	Download
M	chrome/browser/favicon/favicon_handler_unittest.cc	View		24 chunks	+147 lines, -84 lines	0 comments	Download

Total messages: 2 (0 generated)

stevenjb

Extra change to FaviconHandler::OnDidDownloadFavicon to prevent additional downloads caused because current_candidate() wasn't NULL after setting ...

8 years, 9 months ago (2012-03-21 22:25:16 UTC) #1

LGTM