Make continue work in do-while.

frog/leg/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   SsaCodeGeneratorTask(Compiler compiler) : super(compiler);
   String get name() => 'SSA code generator';
 
   String generate(WorkItem work, HGraph graph) {
     return measure(() {
@@ skipping 231 matching lines @@
     int oldPrecedence = this.expectedPrecedence;
     this.expectedPrecedence = expectedPrecedence;
     node.accept(this);
     this.expectedPrecedence = oldPrecedence;
   }
 
   void handleLabeledBlock(HLabeledBlockInformation labeledBlockInfo) {
     addIndentation();
     for (LabelElement label in labeledBlockInfo.labels) {
       if (labeledBlockInfo.isContinue) {
-        addContinueLabel(label);
+        if (label.isContinueTarget) {
+          addContinueLabel(label);
+          buffer.add(':');
+        }
       } else {
-        addBreakLabel(label);
+        if (label.isBreakTarget) {
+          addBreakLabel(label);
+          buffer.add(':');
+        }
       }
-      buffer.add(':');
     }
     TargetElement target = labeledBlockInfo.target;
     if (target.isSwitch) {
       addImplicitBreakLabel(target);
-      buffer.add(@':');
+      buffer.add(':');
     }
     if (labeledBlockInfo.isContinue) {
       addImplicitContinueLabel(target);
       buffer.add(':');
     }
     buffer.add('{\n');
     indent++;
 
     visitSubGraph(labeledBlockInfo.body);
 
@@ skipping 17 matching lines @@
     // don't handle it again.
     if (node.hasLabeledBlockInformation() &&
         node.labeledBlockInformation !== currentBlockInformation) {
       HLabeledBlockInformation oldBlockInformation = currentBlockInformation;
       currentBlockInformation = node.labeledBlockInformation;
       handleLabeledBlock(currentBlockInformation);
       currentBlockInformation = oldBlockInformation;
       return;
     }
 
-    currentBlock = node;
     if (node.isLoopHeader()) {
       // While loop will be closed by the conditional loop-branch.
       // TODO(floitsch): HACK HACK HACK.
       beginLoop(node);
     }
+
+    currentBlock = node;

[ngeoffray, 2012/03/21 12:23:23]

Why this change? I actually think we should get rid of 'currentBlock'.

[Lasse Reichstein Nielsen, 2012/03/21 12:33:26]

Hmm, is it even safe?
I hadn't noticed that currentBlock was an instance field, not a local variable.
It's probably not being used in beginLoop, but I'll move it back just to be
sure.

Then we can check if it can be removed.

     HInstruction instruction = node.first;
     while (instruction != null) {
       if (instruction is HGoto || instruction is HExit || instruction is HTry) {
         visit(instruction, JSPrecedence.STATEMENT_PRECEDENCE);
         return;
       } else if (!instruction.generateAtUseSite()) {
         if (instruction is !HIf && instruction is !HBailoutTarget) {
           addIndentation();
         }
         if (instruction.usedBy.isEmpty() || instruction is HLocal) {
@@ skipping 1169 matching lines @@
       startBailoutSwitch();
     }
   }
 
   void endElse(HIf node) {
     if (node.elseBlock.hasBailouts()) {
       endBailoutSwitch();
     }
   }
 }