Issue 9809021: Dragging files into external apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9809021: Dragging files into external apps. (Closed)

Created:
8 years, 9 months ago by SeRya

Modified:
8 years, 9 months ago

Reviewers:
dgozman

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Dragging files into external apps. BUG=chromium-os:20162 TEST=Drag a file into Google Docs. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128912

Patch Set 2 : Code review fixes. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	chrome/browser/resources/file_manager/js/file_manager.js	View	1	4 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dgozman

LGTM wiht nits https://chromiumcodereview.appspot.com/9809021/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/9809021/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode3140 chrome/browser/resources/file_manager/js/file_manager.js:3140: for(var i = 0, entry; i ...

8 years, 9 months ago (2012-03-26 14:48:54 UTC) #2

SeRya

8 years, 9 months ago (2012-03-26 14:51:32 UTC) #3

https://chromiumcodereview.appspot.com/9809021/diff/1/chrome/browser/resource...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/9809021/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/js/file_manager.js:3140: for(var i = 0,
entry; i < files.length; i++) {
On 2012/03/26 14:48:54, dgozman wrote:
> |entry| is not used

Done.

https://chromiumcodereview.appspot.com/9809021/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/js/file_manager.js:3167: if
(!event.clipboardData.getData('fs/isCut'))
On 2012/03/26 14:48:54, dgozman wrote:
> Add a comment about this check.

Done.

Expand Messages | Collapse Messages

Issue 9809021: Dragging files into external apps. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review fixes. #

Messages