Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 9809010: Fix the return type of the date set methods. (Closed)

Created:
8 years, 9 months ago by ulan
Modified:
8 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix the return type of the date set methods. Date set methods (setMinutes, setHours, etc.) should return the time value as a number instead of JSDate. R=jkummerow@chromium.org TEST=test/mjsunit/regress/regress-2027.js Committed: https://code.google.com/p/v8/source/detail?r=11140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
M src/date.js View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-2027.js View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ulan
Please take a look.
8 years, 9 months ago (2012-03-26 09:18:25 UTC) #1
Jakob Kummerow
8 years, 9 months ago (2012-03-26 09:20:34 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698