Issue 9808111: Fix missing write barrier in CopyObjectToObjectElements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9808111: Fix missing write barrier in CopyObjectToObjectElements. (Closed)

Created:
8 years, 9 months ago by Jakob Kummerow

Modified:
8 years, 9 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix missing write barrier in CopyObjectToObjectElements. Passing the write barrier mode as a parameter does not make sense, as the elements kind specific copiers know best whether a write barrier is needed or not. BUG=119926 TEST=mjsunit/regress/regress-crbug-119926 R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11134

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -29 lines)			Patch
M	src/elements.h	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	src/elements.cc	View	10 chunks	+12 lines, -21 lines	0 comments	Download
M	src/objects.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
A	test/mjsunit/regress/regress-crbug-119926.js	View	1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages