src/elements.cc - Issue 9808110: Check double array bounds in HasElementImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/elements.cc

Issue 9808110: Check double array bounds in HasElementImpl. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Review feedback Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/elements.cc

diff --git a/src/elements.cc b/src/elements.cc

index f6a1697829eb52ea99a36df53eca5befe61bd0ad..ba77de77ce7b4b97f195f4631e6a0e2fa284b102 100644

--- a/src/elements.cc

+++ b/src/elements.cc

@@ -844,7 +844,8 @@ class FastDoubleElementsAccessor

JSObject* holder,

uint32_t key,

FixedDoubleArray* backing_store) {

- return !backing_store->is_the_hole(key);

+ return key < static_cast<uint32_t>(backing_store->length()) &&

+ !backing_store->is_the_hole(key);

}

};

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-119925.js » ('j') | no next file with comments »