Issue 9808110: Check double array bounds in HasElementImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9808110: Check double array bounds in HasElementImpl. (Closed)

Created:
8 years, 9 months ago by danno

Modified:
8 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Check double array bounds in HasElementImpl. R=jkummerow@chromium.org BUG=chromium:119925 TEST=test/mjsunit/regress/regress-119925.js Committed: https://code.google.com/p/v8/source/detail?r=11133

Patch Set 1 #

Patch Set 2 : Remove whitespace #

Total comments: 1

Patch Set 3 : Review feedback #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -1 line)			Patch
	M	src/elements.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
	A	test/mjsunit/regress/regress-119925.js	View	1 2	1 chunk	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 9 months ago (2012-03-25 13:57:52 UTC) #2

LGTM with a nit.

https://chromiumcodereview.appspot.com/9808110/diff/2001/test/mjsunit/regress...
File test/mjsunit/regress/regress-119925.js (right):

https://chromiumcodereview.appspot.com/9808110/diff/2001/test/mjsunit/regress...
test/mjsunit/regress/regress-119925.js:1: // Copyright 2011 the V8 project
authors. All rights reserved.
2012

Expand Messages | Collapse Messages