Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9689)

Unified Diff: chrome/common/extensions/url_pattern_unittest.cc

Issue 9808101: Revert 128753 - Add full support for filesystem URLs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/url_pattern_unittest.cc
===================================================================
--- chrome/common/extensions/url_pattern_unittest.cc (revision 128756)
+++ chrome/common/extensions/url_pattern_unittest.cc (working copy)
@@ -110,11 +110,6 @@
EXPECT_TRUE(pattern.MatchesURL(GURL("https://www.google.com/foobar")));
EXPECT_FALSE(pattern.MatchesURL(GURL("http://www.google.com/foo")));
EXPECT_FALSE(pattern.MatchesURL(GURL("https://www.google.com/")));
- EXPECT_FALSE(pattern.MatchesURL(
- GURL("filesystem:https://www.google.com/foobar/")));
- pattern.set_partial_filesystem_support_hack(true);
- EXPECT_TRUE(pattern.MatchesURL(
- GURL("filesystem:https://www.google.com/foobar/bas")));
}
// subdomains
@@ -132,11 +127,6 @@
EXPECT_TRUE(pattern.MatchesURL(
GURL("http://monkey.images.google.com/foooobar")));
EXPECT_FALSE(pattern.MatchesURL(GURL("http://yahoo.com/foobar")));
- EXPECT_FALSE(pattern.MatchesURL(
- GURL("filesystem:http://google.com/foobar/")));
- pattern.set_partial_filesystem_support_hack(true);
- EXPECT_FALSE(pattern.MatchesURL(
- GURL("filesystem:http://google.com/temporary/foobar")));
}
// glob escaping
@@ -236,7 +226,6 @@
EXPECT_TRUE(pattern.MatchesScheme("http"));
EXPECT_TRUE(pattern.MatchesScheme("https"));
EXPECT_TRUE(pattern.MatchesScheme("file"));
- EXPECT_TRUE(pattern.MatchesScheme("filesystem"));
EXPECT_TRUE(pattern.MatchesScheme("chrome-extension"));
EXPECT_TRUE(pattern.match_subdomains());
EXPECT_TRUE(pattern.match_all_urls());
@@ -268,7 +257,6 @@
EXPECT_TRUE(pattern.MatchesScheme("http"));
EXPECT_TRUE(pattern.MatchesScheme("https"));
EXPECT_TRUE(pattern.MatchesScheme("file"));
- EXPECT_TRUE(pattern.MatchesScheme("filesystem"));
EXPECT_TRUE(pattern.MatchesScheme("javascript"));
EXPECT_TRUE(pattern.MatchesScheme("data"));
EXPECT_TRUE(pattern.MatchesScheme("about"));
@@ -380,11 +368,6 @@
EXPECT_TRUE(pattern.MatchesURL(GURL("http://www.example.com:80/foo")));
EXPECT_TRUE(pattern.MatchesURL(GURL("http://www.example.com/foo")));
EXPECT_FALSE(pattern.MatchesURL(GURL("http://www.example.com:8080/foo")));
- EXPECT_FALSE(pattern.MatchesURL(
- GURL("filesystem:http://www.example.com:8080/foo/")));
- EXPECT_FALSE(pattern.MatchesURL(GURL("filesystem:http://www.example.com/f/foo")));
- pattern.set_partial_filesystem_support_hack(true);
- EXPECT_FALSE(pattern.MatchesURL(GURL("filesystem:http://www.example.com/f/foo")));
}
// Explicit port wildcard
@@ -401,8 +384,6 @@
EXPECT_TRUE(pattern.MatchesURL(GURL("http://www.example.com:80/foo")));
EXPECT_TRUE(pattern.MatchesURL(GURL("http://www.example.com/foo")));
EXPECT_TRUE(pattern.MatchesURL(GURL("http://www.example.com:8080/foo")));
- EXPECT_FALSE(pattern.MatchesURL(
- GURL("filesystem:http://www.example.com:8080/foo/")));
}
// chrome-extension://
@@ -421,11 +402,6 @@
EXPECT_TRUE(pattern.MatchesURL(
GURL("chrome-extension://ftw/https://google.com")));
EXPECT_FALSE(pattern.MatchesURL(GURL("chrome-extension://foobar")));
- EXPECT_FALSE(pattern.MatchesURL(
- GURL("filesystem:chrome-extension://ftw/t/file.txt")));
- pattern.set_partial_filesystem_support_hack(true);
- EXPECT_TRUE(pattern.MatchesURL(
- GURL("filesystem:chrome-extension://ftw/t/file.txt")));
};
static const struct GetAsStringPatterns {
« no previous file with comments | « chrome/common/extensions/url_pattern.cc ('k') | chrome/test/data/extensions/api_test/filebrowser_component/main.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698