Proper support for sequence<T> in IDLs.

Proper support for sequence<T> in IDLs.

And generalise Vector to Dart conversion.

Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=310

[Anton Muhin, 2012-03-22 22:12:30]

Depends on https://chromiumcodereview.appspot.com/9843003/

https://chromiumcodereview.appspot.com/9808037/diff/1/Source/WebCore/page/Con...
File Source/WebCore/page/Console.idl (left):

https://chromiumcodereview.appspot.com/9808037/diff/1/Source/WebCore/page/Con...
Source/WebCore/page/Console.idl:49: // readonly attribute
sequence<ScriptProfile> profiles;
I remember you asked me not to comment out parts of IDLs, but it handy as now
you don't need two-sided patches.  Let's discuss face-to-face if I am missing
some simple solution here.

[podivilov, 2012-03-23 15:44:12]

lgtm

http://codereview.chromium.org/9808037/diff/1/Source/WebCore/bindings/dart/Da...
File Source/WebCore/bindings/dart/DartDOMWrapper.h (right):

http://codereview.chromium.org/9808037/diff/1/Source/WebCore/bindings/dart/Da...
Source/WebCore/bindings/dart/DartDOMWrapper.h:221: // FIXME: provide
specialization for PassRefPtr as well
We are generating toDartValue(PassRefPtr<T>) to guarantee that toDartValue(T) is
declared before it.

http://codereview.chromium.org/9808037/diff/1/Source/WebCore/page/Console.idl
File Source/WebCore/page/Console.idl (left):

http://codereview.chromium.org/9808037/diff/1/Source/WebCore/page/Console.idl...
Source/WebCore/page/Console.idl:49: // readonly attribute
sequence<ScriptProfile> profiles;
On 2012/03/22 22:12:30, antonmuhin wrote:
> I remember you asked me not to comment out parts of IDLs, but it handy as now
> you don't need two-sided patches.  Let's discuss face-to-face if I am missing
> some simple solution here.

The idea is to revert this change right after committing dart generator part,
right?

[Anton Muhin, 2012-03-23 17:29:23]

http://codereview.chromium.org/9808037/diff/1/Source/WebCore/bindings/dart/Da...
File Source/WebCore/bindings/dart/DartDOMWrapper.h (right):

http://codereview.chromium.org/9808037/diff/1/Source/WebCore/bindings/dart/Da...
Source/WebCore/bindings/dart/DartDOMWrapper.h:221: // FIXME: provide
specialization for PassRefPtr as well
On 2012/03/23 15:44:12, podivilov wrote:
> We are generating toDartValue(PassRefPtr<T>) to guarantee that toDartValue(T)
is
> declared before it.

Thanks a lot for bringing this.  I still hope that if we put this into
DartDOMWrapper.h, everything should work smooth.  Am I missing anything?

[podivilov, 2012-03-26 09:45:07]

http://codereview.chromium.org/9808037/diff/1/Source/WebCore/bindings/dart/Da...
File Source/WebCore/bindings/dart/DartDOMWrapper.h (right):

http://codereview.chromium.org/9808037/diff/1/Source/WebCore/bindings/dart/Da...
Source/WebCore/bindings/dart/DartDOMWrapper.h:221: // FIXME: provide
specialization for PassRefPtr as well
On 2012/03/23 17:29:23, antonmuhin wrote:
> On 2012/03/23 15:44:12, podivilov wrote:
> > We are generating toDartValue(PassRefPtr<T>) to guarantee that
toDartValue(T)
> is
> > declared before it.
> 
> Thanks a lot for bringing this.  I still hope that if we put this into
> DartDOMWrapper.h, everything should work smooth.  Am I missing anything?

DartArrayBuffer.h generated header looks like this:

#include "DartDOMWrapper.h"
...
Dart_Handle toDartValue(ArrayBuffer* value)
{
...
}

If toDartValue(PassRefPtr<T>) is defined in DartDOMWrapper.h, it would not
compile because ArrayBuffer is defined in namespace WTF.