Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 9808037: Proper support for sequence<T> in IDLs. (Closed)

Created:
8 years, 9 months ago by Anton Muhin
Modified:
8 years, 9 months ago
Reviewers:
podivilov
CC:
reviews+dom_dartlang.org
Visibility:
Public.

Description

Proper support for sequence<T> in IDLs. And generalise Vector to Dart conversion. Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=310

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -22 lines) Patch
M Source/WebCore/bindings/dart/DartDOMWrapper.h View 1 chunk +8 lines, -18 lines 3 comments Download
M Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/WebCore/page/Console.idl View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
Anton Muhin
Depends on https://chromiumcodereview.appspot.com/9843003/ https://chromiumcodereview.appspot.com/9808037/diff/1/Source/WebCore/page/Console.idl File Source/WebCore/page/Console.idl (left): https://chromiumcodereview.appspot.com/9808037/diff/1/Source/WebCore/page/Console.idl#oldcode49 Source/WebCore/page/Console.idl:49: // readonly attribute sequence<ScriptProfile> profiles; I ...
8 years, 9 months ago (2012-03-22 22:12:30 UTC) #1
podivilov
lgtm http://codereview.chromium.org/9808037/diff/1/Source/WebCore/bindings/dart/DartDOMWrapper.h File Source/WebCore/bindings/dart/DartDOMWrapper.h (right): http://codereview.chromium.org/9808037/diff/1/Source/WebCore/bindings/dart/DartDOMWrapper.h#newcode221 Source/WebCore/bindings/dart/DartDOMWrapper.h:221: // FIXME: provide specialization for PassRefPtr as well ...
8 years, 9 months ago (2012-03-23 15:44:12 UTC) #2
Anton Muhin
http://codereview.chromium.org/9808037/diff/1/Source/WebCore/bindings/dart/DartDOMWrapper.h File Source/WebCore/bindings/dart/DartDOMWrapper.h (right): http://codereview.chromium.org/9808037/diff/1/Source/WebCore/bindings/dart/DartDOMWrapper.h#newcode221 Source/WebCore/bindings/dart/DartDOMWrapper.h:221: // FIXME: provide specialization for PassRefPtr as well On ...
8 years, 9 months ago (2012-03-23 17:29:23 UTC) #3
Anton Muhin
8 years, 9 months ago (2012-03-23 17:29:27 UTC) #4
podivilov
8 years, 9 months ago (2012-03-26 09:45:07 UTC) #5
http://codereview.chromium.org/9808037/diff/1/Source/WebCore/bindings/dart/Da...
File Source/WebCore/bindings/dart/DartDOMWrapper.h (right):

http://codereview.chromium.org/9808037/diff/1/Source/WebCore/bindings/dart/Da...
Source/WebCore/bindings/dart/DartDOMWrapper.h:221: // FIXME: provide
specialization for PassRefPtr as well
On 2012/03/23 17:29:23, antonmuhin wrote:
> On 2012/03/23 15:44:12, podivilov wrote:
> > We are generating toDartValue(PassRefPtr<T>) to guarantee that
toDartValue(T)
> is
> > declared before it.
> 
> Thanks a lot for bringing this.  I still hope that if we put this into
> DartDOMWrapper.h, everything should work smooth.  Am I missing anything?

DartArrayBuffer.h generated header looks like this:

#include "DartDOMWrapper.h"
...
Dart_Handle toDartValue(ArrayBuffer* value)
{
...
}

If toDartValue(PassRefPtr<T>) is defined in DartDOMWrapper.h, it would not
compile because ArrayBuffer is defined in namespace WTF.

Powered by Google App Engine
This is Rietveld 408576698