Layout panels on top of their launcher icons

ash/launcher/launcher.h

Index: ash/launcher/launcher.h
diff --git a/ash/launcher/launcher.h b/ash/launcher/launcher.h
index ebc56b8353409fe7cb407718621c1dc0537055d0..4750ffb499cfe584c95c52e0faf9a500d8ea3b50 100644
--- a/ash/launcher/launcher.h
+++ b/ash/launcher/launcher.h
@@ -30,6 +30,7 @@ class FocusCycler;
 class LauncherView;
 }
 
+class LauncherIconsObserver;

[sky, 2012/04/03 20:39:37]

Name this class LauncherIconObserver.

[Dmitry Lomov (no reviews), 2012/04/03 20:50:07]

Why? It observes all icons, you cannot observe a particular icon.
[I am not a native English speaker; let me know if it is imposssible gramar in
English]

[sky, 2012/04/03 20:57:18]

For a similar reason that we have TabModel and not TabsModel.

[Dmitry Lomov (no reviews), 2012/04/03 21:18:23]

And that reason is...?

[stevenjb, 2012/04/03 22:09:29]

Typically observer and delegate classes are named with the type of thing they
are watching. The details of which ones or how many are not part of the class
name. Also, in english one always says "Bird Watcher", not "Birds Watcher", even
though more than one bird is typically watched.

 class LauncherDelegate;
 class LauncherModel;
 
@@ -56,6 +57,9 @@ class ASH_EXPORT Launcher : public internal::BackgroundAnimatorDelegate {
   // no item for the specified window an empty rect is returned.
   gfx::Rect GetScreenBoundsOfItemIconForWindow(aura::Window* window);
 
+  void AddIconsObserver(LauncherIconsObserver* observer);
+  void RemoveIconsObserver(LauncherIconsObserver* observer);
+
   // Returns true if the Launcher is showing a context menu.
   bool IsShowingMenu() const;