Layout panels on top of their launcher icons

ash/test/test_launcher_delegate.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/launcher/launcher_model.h"
+#include "ash/test/test_launcher_delegate.h"

[sky, 2012/04/11 15:47:49]

this should be your first include.

+#include "base/utf_string_conversions.h"
+#include "grit/ui_resources.h"
+
+namespace ash {
+namespace test {
+
+TestLauncherDelegate::TestLauncherDelegate(LauncherModel* model)
+   : model_(model) {

[sky, 2012/04/11 15:47:49]

nit: 4 space indent.

+}
+
+void TestLauncherDelegate::CreateNewTab() {
+  CreateNewWindow();

[sky, 2012/04/11 15:47:49]

Any point in having this since CreateNewWindow does nothing?

+}
+
+void TestLauncherDelegate::CreateNewWindow() {
+}
+
+void TestLauncherDelegate::ItemClicked(const ash::LauncherItem& item) {
+  //aura::Window* window = watcher_->GetWindowByID(item.id);

[sky, 2012/04/11 15:47:49]

?

+  //window->Show();
+  //ash::wm::ActivateWindow(window);
+}
+
+int TestLauncherDelegate::GetBrowserShortcutResourceId() {
+  return IDR_AURA_LAUNCHER_BROWSER_SHORTCUT;
+}
+
+string16 TestLauncherDelegate::GetTitle(const ash::LauncherItem& item) {
+  return string16(ASCIIToUTF16(""));

[sky, 2012/04/11 15:47:49]

return string16();

+}
+
+ui::MenuModel* TestLauncherDelegate::CreateContextMenu(
+    const ash::LauncherItem& item) {
+  return NULL;
+}
+
+ui::MenuModel* TestLauncherDelegate::CreateContextMenuForLauncher() {
+  return NULL;
+}
+
+ash::LauncherID TestLauncherDelegate::GetIDByWindow(aura::Window* window) {
+  WindowToID::const_iterator found = window_to_id_.find(window);
+  if (found == window_to_id_.end()) return 0;

[sky, 2012/04/11 15:47:49]

avoid single line ifs.

+  return found->second;
+}
+
+void TestLauncherDelegate::AddLauncherItem(aura::Window* window) {
+  ash::LauncherItem item;
+  item.type = ash::TYPE_TABBED;
+  window_to_id_[window] = model_->next_id();
+  item.image.setConfig(SkBitmap::kARGB_8888_Config, 16, 16);
+  item.image.allocPixels();
+  model_->Add(item);
+}
+
+

[sky, 2012/04/11 15:47:49]

only one newline.

+
+} // namespace test
+} // namespace ash