ash/launcher/launcher_icons_observer.h - Issue 9808026: Layout panels on top of their launcher icons

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/launcher/launcher_icons_observer.h

Issue 9808026: Layout panels on top of their launcher icons (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ununsed constanrs removed Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1

	2 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	3 // Use of this source code is governed by a BSD-style license that can be

	4 // found in the LICENSE file.

	5

	6 #ifndef ASH_LAUNCHER_LAUNCHER_ICONS_OBSERVER_H_

	7 #define ASH_LAUNCHER_LAUNCHER_ICONS_OBSERVER_H_

	8 #pragma once

	9

	10 namespace ash {

	11

	12 class ASH_EXPORT LauncherIconsObserver {
	sky 2012/03/23 21:41:14 Name this LauncherViewObserver. Name this LauncherViewObserver. Dmitry Lomov (no reviews) 2012/03/23 22:40:35 Here is a bit bigger issue. I'd rather expose Laun Show quoted text On 2012/03/23 21:41:14, sky wrote: > Name this LauncherViewObserver. Here is a bit bigger issue. I'd rather expose LauncherView getter on Launcher, rename this class into LauncherViewObserver and move Add/RemoveObserver for it onto LauncherView. Besides being cleaner, this will help to handle auto-hide stuff as well.
	13 public:

	14 virtual void OnLauncherIconPositionsChanged() = 0;

	15 };
	sky 2012/03/23 21:41:14 Add protected virtual destructor. Add protected virtual destructor.
	16

	17 } // namespace ash

	18

	19 #endif // ASH_LAUNCHER_LAUNCHER_ICONS_OBSERVER_H_

OLD	NEW