Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4700)

Unified Diff: chrome/browser/resources/test_presubmit.py

Issue 9808002: [WebUI] Make CSS presubmit play nice with grit XML. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: s/for/filter/ Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/test_presubmit.py
diff --git a/chrome/browser/resources/test_presubmit.py b/chrome/browser/resources/test_presubmit.py
index 3a51ebcdc88bb00252a2d840ca1ac914886c9712..b9de0d72b08907e7bbddd24b104270510e5903e6 100755
--- a/chrome/browser/resources/test_presubmit.py
+++ b/chrome/browser/resources/test_presubmit.py
@@ -60,13 +60,31 @@ class WebDevStyleGuideTest(SuperMoxTestBase):
def testCssAlphaWithAtBlock(self):
self.VerifyContentsProducesOutput("""
+<include src="../shared/css/cr/ui/overlay.css">
+<include src="chrome://resources/totally-cool.css" />
+
/* A hopefully safely ignored comment and @media statement. /**/
@media print {
div {
display: block;
color: red;
}
-}""", """
+<if expr="not is macosx">
+ background-image: url(chrome://resources/BLAH); /* TODO(dbeam): Fix this. */
+ background-color: rgb(235, 239, 249);
+</if>
+<if expr="is_macosx">
+ background-color: white;
+ background-image: url(chrome://resources/BLAH2);
+</if>
+}
+
+<if expr="is_macosx">
+.language-options-right {
+ visibility: hidden;
+ opacity: 1; /* TODO(dbeam): Fix this. */
+}
+</if>""", """
- Alphabetize properties and list vendor specific (i.e. -webkit) above standard.
display: block;
color: red;""")

Powered by Google App Engine
This is Rietveld 408576698