chrome/browser/resources/PRESUBMIT.py - Issue 9808002: [WebUI] Make CSS presubmit play nice with grit XML.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/PRESUBMIT.py

Issue 9808002: [WebUI] Make CSS presubmit play nice with grit XML. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: dpranke review Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/PRESUBMIT.py

diff --git a/chrome/browser/resources/PRESUBMIT.py b/chrome/browser/resources/PRESUBMIT.py

index 292836a15b5e832f6bdcfb95e8110f2ab67a3b25..76f08ad62e4f450663ddf1c6b6e9fe6427d04e76 100644

--- a/chrome/browser/resources/PRESUBMIT.py

+++ b/chrome/browser/resources/PRESUBMIT.py

@@ -25,8 +25,14 @@ def _CommonChecks(input_api, output_api):

resources = input_api.PresubmitLocalPath()

path = input_api.os_path

- presubmit = path.join(resources, 'PRESUBMIT.py')

- if presubmit in (f.AbsoluteLocalPath() for f in input_api.AffectedFiles()):

+ affected_files = (f.AbsoluteLocalPath() for f in input_api.AffectedFiles())

+ would_affect_tests = (

+ path.join(resources, 'PRESUBMIT.py'),

+ path.join(resources, 'test_presubmit.py'),

+ path.join(resources, 'web_dev_style', 'css_checker.py'),

+ path.join(resources, 'web_dev_style', 'js_checker.py'),

+ )

+ if any(f for f in affected_files if f in would_affect_tests):

tests = [path.join(resources, 'test_presubmit.py')]

results.extend(

input_api.canned_checks.RunUnitTests(input_api, output_api, tests))

« no previous file with comments | « no previous file | chrome/browser/resources/test_presubmit.py » ('j') | no next file with comments »