Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: Source/WebCore/dom/CheckedRadioButtons.h

Issue 9805002: Revert 105710 - Introduce RadioButtonGroup class to keep track of the group members and required st… (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/perf/adding-radio-buttons-expected.txt ('k') | Source/WebCore/dom/CheckedRadioButtons.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/dom/CheckedRadioButtons.h
===================================================================
--- Source/WebCore/dom/CheckedRadioButtons.h (revision 111481)
+++ Source/WebCore/dom/CheckedRadioButtons.h (working copy)
@@ -28,24 +28,16 @@
namespace WebCore {
class HTMLInputElement;
-class RadioButtonGroup;
-// FIXME: Rename the class. The class was a simple map from a name to a checked
-// radio button. It manages RadioButtonGroup objects now.
class CheckedRadioButtons {
public:
- CheckedRadioButtons();
- ~CheckedRadioButtons();
void addButton(HTMLInputElement*);
- void updateCheckedState(HTMLInputElement*);
- void requiredAttributeChanged(HTMLInputElement*);
void removeButton(HTMLInputElement*);
HTMLInputElement* checkedButtonForGroup(const AtomicString& groupName) const;
- bool isInRequiredGroup(HTMLInputElement*) const;
private:
- typedef HashMap<AtomicStringImpl*, OwnPtr<RadioButtonGroup> > NameToGroupMap;
- OwnPtr<NameToGroupMap> m_nameToGroupMap;
+ typedef HashMap<AtomicStringImpl*, HTMLInputElement*> NameToInputMap;
+ OwnPtr<NameToInputMap> m_nameToCheckedRadioButtonMap;
};
} // namespace WebCore
« no previous file with comments | « LayoutTests/perf/adding-radio-buttons-expected.txt ('k') | Source/WebCore/dom/CheckedRadioButtons.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698