[windows] Make calls to exit(), _exit(), abort(), and ExitProcess() from the renderer process resul…

chrome/app/breakpad_win.cc

Index: chrome/app/breakpad_win.cc
diff --git a/chrome/app/breakpad_win.cc b/chrome/app/breakpad_win.cc
index 9bd8e1ec669e3d713e951565c58fe258b92e74e1..d1e984eccd7980c7636bb8a3c66e50a9506a1b25 100644
--- a/chrome/app/breakpad_win.cc
+++ b/chrome/app/breakpad_win.cc
@@ -520,7 +520,8 @@ bool WrapMessageBoxWithSEH(const wchar_t* text, const wchar_t* caption,
     *exit_now = (IDOK != ::MessageBoxW(NULL, text, caption, flags));
   } __except(EXCEPTION_EXECUTE_HANDLER) {
     // Its not safe to continue executing, exit silently here.
-    ::ExitProcess(chrome::RESULT_CODE_RESPAWN_FAILED);
+    ::TerminateProcess(::GetCurrentProcess(),

[rvargas (doing something else), 2012/03/21 03:13:45]

Don't you want to reset the flag from this place instead?

[eroman, 2012/03/21 04:14:31]

(Didn't reset because was harder; this code is running in chrome.exe)

I think as far as correctness is concerned TerminateProcess() is good, since I
can't imagine wanting to run the shutdown code when badness has happened.

But I can certainly change that.

[rvargas (doing something else), 2012/03/21 17:46:12]

Right, the exe... TerminateProcess sounds good. (There's still some concern
about people copying this code and going around your patch, but hopefully they
won't)

+                       chrome::RESULT_CODE_RESPAWN_FAILED);
   }
 
   return true;
@@ -570,7 +571,7 @@ extern "C" int __declspec(dllexport) CrashForException(
     EXCEPTION_POINTERS* info) {
   if (g_breakpad) {
     g_breakpad->WriteMinidumpForException(info);
-    ::ExitProcess(content::RESULT_CODE_KILLED);
+    ::TerminateProcess(::GetCurrentProcess(), content::RESULT_CODE_KILLED);
   }
   return EXCEPTION_CONTINUE_SEARCH;
 }