Issue 9802035: Revert "Close the screenshot flash effect before the screenshot task is actually executed."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9802035: Revert "Close the screenshot flash effect before the screenshot task is actually executed." (Closed)

Created:
8 years, 9 months ago by Emmanuel Saint-loubert-Bié

Modified:
8 years, 9 months ago

Reviewers:
Jun Mukai, Daniel Erat, piman

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Close the screenshot flash effect before the screenshot task is actually executed." This reverts commit b6c13fe860b4d64759eab3a60b328b6cd4dc64c7. TBR=mukai@chromium.org R=saintlou@chromium.org BUG=120601 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129442

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	chrome/browser/ui/views/ash/screenshot_taker.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emmanuel Saint-loubert-Bié

As discussed we are reverting https://src.chromium.org/viewvc/chrome?view=rev&revision=128925 which introduced: http://code.google.com/p/chromium/issues/detail?id=120601

8 years, 9 months ago (2012-03-28 18:05:50 UTC) #2

lgtm

Expand Messages | Collapse Messages