lib/compiler/implementation/compile_time_constants.dart - Issue 9802023: Correctly handle constness for list and map literals inside bodies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/compile_time_constants.dart

Issue 9802023: Correctly handle constness for list and map literals inside bodies. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add TODOs. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/compile_time_constants.dart

diff --git a/lib/compiler/implementation/compile_time_constants.dart b/lib/compiler/implementation/compile_time_constants.dart

index 94c98c5f9b08edbfd6af8cfd32eb8b6b882bee4e..4472547c9653d75cb8174a4c76d93c3a6a0c6b07 100644

--- a/lib/compiler/implementation/compile_time_constants.dart

+++ b/lib/compiler/implementation/compile_time_constants.dart

@@ -710,8 +710,7 @@ class CompileTimeConstantEvaluator extends AbstractVisitor {

}

Constant visitLiteralMap(LiteralMap node) {

- // TODO(floitsch): check for isConst, once the parser adds it into the node.

- // if (!node.isConst()) error(node);

+ if (!node.isConst()) error(node);

List<StringConstant> keys = <StringConstant>[];

List<Constant> values = <Constant>[];

bool hasProtoKey = false;

« no previous file with comments | « no previous file | lib/compiler/implementation/scanner/listener.dart » ('j') | no next file with comments »