Issue 9796013: Set sourceUrl property of mountpoint info for gdata to empty string if mount fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9796013: Set sourceUrl property of mountpoint info for gdata to empty string if mount fails. (Closed)

Created:
8 years, 9 months ago by tbarzic

Modified:
2 years, 5 months ago

Reviewers:
achuithb, zel

CC:
chromium-reviews, nkostylev+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Set sourceUrl property of mountpoint info for gdata to empty string if mount fails. BUG=chromium-os:28112 TEST=manual on linux chromeos (verified we don't crash on debug build with no profile dir set) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127992

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/extensions/file_browser_event_router.cc	View		1 chunk	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

achuithb

8 years, 9 months ago (2012-03-21 19:38:28 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/9796013/diff/1/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/file_browser_event_router.cc (right):

https://chromiumcodereview.appspot.com/9796013/diff/1/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/file_browser_event_router.cc:374: // If
mounting of gdata moutn point failed, we may not be able to convert
nit: moutn->mount

Expand Messages | Collapse Messages