[webui] get rid of more html[os=] rules

[webui] get rid of more html[os=] rules

BUG=118298
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129067

[Dan Beam, 2012-03-21 03:02:53]

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/bookma...
File chrome/browser/resources/bookmark_manager/css/bmm.css (right):

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/bookma...
chrome/browser/resources/bookmark_manager/css/bmm.css:177: background-image:
url("../../../../app/theme/bookmark_bar_folder_mac.png");
er, wat? seems like this line is duplicated...? also, single quotes if you feel
like it, and there are alpha issues everywhere, :(

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/bookma...
chrome/browser/resources/bookmark_manager/css/bmm.css:222: <if expr="is_macosx">
We should establish how we override styles for just 1 OS, as it seems like we
should be saying <if expr="not is_macosx"> or <else> or something, here. (is
there an <else>?)

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/shared...
File chrome/browser/resources/shared/css/menu.css (left):

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/shared...
chrome/browser/resources/shared/css/menu.css:54: * TODO(estade):
http://crbug.com/88688. */
where is the equivalent of this?

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/sync_i...
File chrome/browser/resources/sync_internals/sync_search.css (right):

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/sync_i...
chrome/browser/resources/sync_internals/sync_search.css:21: /* min-width and
max-width are used by the split pane. */
no ^\s*

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/sync_i...
chrome/browser/resources/sync_internals/sync_search.css:38: /* TODO(akalin):
Make the BMM also use this style. */
I smell copy pasta, but whatevs.

[csilv, 2012-03-21 19:35:22]

lgtm

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/bookma...
File chrome/browser/resources/bookmark_manager/css/bmm.css (right):

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/bookma...
chrome/browser/resources/bookmark_manager/css/bmm.css:222: <if expr="is_macosx">
On 2012/03/21 03:02:53, Dan Beam wrote:
> We should establish how we override styles for just 1 OS, as it seems like we
> should be saying <if expr="not is_macosx"> or <else> or something, here. (is
> there an <else>?)

<else> would be nice, but it doesn't exist yet. 
http://code.google.com/p/grit-i18n/ if you're interested.  :-)

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/shared...
File chrome/browser/resources/shared/css/menu.css (left):

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/shared...
chrome/browser/resources/shared/css/menu.css:54: * TODO(estade):
http://crbug.com/88688. */
On 2012/03/21 03:02:53, Dan Beam wrote:
> where is the equivalent of this?

Bug has been fixed so I assume this is obsolete

[Evan Stade, 2012-03-21 21:51:11]

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/bookma...
File chrome/browser/resources/bookmark_manager/css/bmm.css (right):

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/bookma...
chrome/browser/resources/bookmark_manager/css/bmm.css:177: background-image:
url("../../../../app/theme/bookmark_bar_folder_mac.png");
On 2012/03/21 03:02:53, Dan Beam wrote:
> er, wat? seems like this line is duplicated...? also, single quotes if you
feel
> like it, and there are alpha issues everywhere, :(

yea i have no idea. I just copied it. I'm not trying to rewrite or fix anything.

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/shared...
File chrome/browser/resources/shared/css/menu.css (left):

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/shared...
chrome/browser/resources/shared/css/menu.css:54: * TODO(estade):
http://crbug.com/88688. */
On 2012/03/21 19:35:22, csilv wrote:
> On 2012/03/21 03:02:53, Dan Beam wrote:
> > where is the equivalent of this?
> 
> Bug has been fixed so I assume this is obsolete

yea it's fixed, I tested in linux and chromeos.

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/sync_i...
File chrome/browser/resources/sync_internals/sync_search.css (right):

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/sync_i...
chrome/browser/resources/sync_internals/sync_search.css:21: /* min-width and
max-width are used by the split pane. */
On 2012/03/21 03:02:53, Dan Beam wrote:
> no ^\s*

Done.

[Dan Beam, 2012-03-21 23:14:51]

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/bookma...
File chrome/browser/resources/bookmark_manager/css/bmm.css (right):

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/bookma...
chrome/browser/resources/bookmark_manager/css/bmm.css:177: background-image:
url("../../../../app/theme/bookmark_bar_folder_mac.png");
On 2012/03/21 21:51:12, Evan Stade wrote:
> On 2012/03/21 03:02:53, Dan Beam wrote:
> > er, wat? seems like this line is duplicated...? also, single quotes if you
> feel
> > like it, and there are alpha issues everywhere, :(
> 
> yea i have no idea. I just copied it. I'm not trying to rewrite or fix
anything.

I'm saying the exactly same rule is repeated twice according to the diff, so
it'd look like:

  background-image: url("../../../../app/theme/bookmark_bar_folder_mac.png");
  background-image: url("../../../../app/theme/bookmark_bar_folder_mac.png");

does it look like this for you in the code or is this a rietveld (or me) issue?

[Evan Stade, 2012-03-21 23:54:03]

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/bookma...
File chrome/browser/resources/bookmark_manager/css/bmm.css (right):

http://codereview.chromium.org/9794016/diff/1/chrome/browser/resources/bookma...
chrome/browser/resources/bookmark_manager/css/bmm.css:177: background-image:
url("../../../../app/theme/bookmark_bar_folder_mac.png");
On 2012/03/21 23:14:51, Dan Beam wrote:
> On 2012/03/21 21:51:12, Evan Stade wrote:
> > On 2012/03/21 03:02:53, Dan Beam wrote:
> > > er, wat? seems like this line is duplicated...? also, single quotes if you
> > feel
> > > like it, and there are alpha issues everywhere, :(
> > 
> > yea i have no idea. I just copied it. I'm not trying to rewrite or fix
> anything.
> 
> I'm saying the exactly same rule is repeated twice according to the diff, so
> it'd look like:
> 
>   background-image: url("../../../../app/theme/bookmark_bar_folder_mac.png");
>   background-image: url("../../../../app/theme/bookmark_bar_folder_mac.png");
> 
> does it look like this for you in the code or is this a rietveld (or me)
issue?

oh, I see what you mean. I will fix it. I thought you were talking about the
selectors, which seem redundant to me.

[Evan Stade, 2012-03-23 17:49:38]

updated

[commit-bot: I haz the power, 2012-03-23 22:25:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/9794016/10001

[commit-bot: I haz the power, 2012-03-23 22:25:18]

Presubmit check for 9794016-10001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.(?: \*/)?\n
Found a bad license header in these files:
  chrome/browser/resources/shared/css/tree.css

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Dan Beam, 2012-03-24 00:59:32]

lgtm

[commit-bot: I haz the power, 2012-03-26 19:02:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/9794016/10001

[commit-bot: I haz the power, 2012-03-26 19:02:25]

Presubmit check for 9794016-10001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.(?: \*/)?\n
Found a bad license header in these files:
  chrome/browser/resources/shared/css/tree.css

Presubmit checks took 1.4s to calculate.

[commit-bot: I haz the power, 2012-03-26 20:53:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/9794016/19001