Issue 9792001: Roll Skia to 3470, which changes most of the pdf includes to be private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9792001: Roll Skia to 3470, which changes most of the pdf includes to be private. (Closed)

Created:
8 years, 9 months ago by vandebo (ex-Chrome)

Modified:
8 years, 9 months ago

Reviewers:
Nico, kmadhusu

CC:
chromium-reviews, skia-dev_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Roll Skia to 3470, which changes most of the pdf includes to be private. TBR=thakis BUG=NONE TEST=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128408

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -32 lines)			Patch
M	DEPS	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/pdf_metafile_skia.cc	View	1 2 3 4 5 6	3 chunks	+13 lines, -18 lines	0 comments	Download
M	skia/skia.gyp	View	1 2 3 4	5 chunks	+13 lines, -13 lines	0 comments	Download

Total messages: 5 (0 generated)

vandebo (ex-Chrome)

Can you review the printing code before I commit the skia side that will require ...

8 years, 9 months ago (2012-03-21 16:43:48 UTC) #1

vandebo (ex-Chrome)

Control CL: https://chromiumcodereview.appspot.com/9835024/

8 years, 9 months ago (2012-03-22 21:03:35 UTC) #3

lgtm