Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: compiler/scripts/dartc.sh

Issue 9791073: On dartc invocation, adds -client flag to non-mac builds if not running in batch mode (tests) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/scripts/dartc.sh
diff --git a/compiler/scripts/dartc.sh b/compiler/scripts/dartc.sh
index 44e2e4dfbc952fd5a3e50e66223afa8aef661b24..dc866fc58c98ba49d674984a2e524dc9054d8409 100755
--- a/compiler/scripts/dartc.sh
+++ b/compiler/scripts/dartc.sh
@@ -21,7 +21,25 @@ if [ "$OS" == "darwin" ] ; then
# Users can specify DART_JVMARGS in the environment to override
# this setting. Force to 32 bit client vm. 64 bit and server VM make for
# poor performance.
- EXTRA_JVMARGS+="-Xmx256M -client -d32"
+ EXTRA_JVMARGS+=" -Xmx256M -client -d32 "
+else
+ # On other architectures
+ # -batch invocations will do better with a server vm
+ # invocations for analyzing a single file do better with a client vm
+ FOUND_BATCH=0
+ for ARG in "$@"
+ do
+ case $ARG in
+ -batch|--batch)
+ FOUND_BATCH=1
+ ;;
+ *)
+ ;;
+ esac
+ done
+ if [ $FOUND_BATCH = 0 ] ; then
+ EXTRA_JVMARGS+=" -client "
+ fi
fi
exec java $EXTRA_JVMARGS $DART_JVMARGS -ea -classpath "@CLASSPATH@" \
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698