Issue 9791072: ash: New ethernet icon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9791072: ash: New ethernet icon. (Closed)

Created:
8 years, 9 months ago by sadrul

Modified:
8 years, 9 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: New ethernet icon. BUG=120575 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129438

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, --1 lines)			Patch
	M	chrome/app/theme/statusbar_wired.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 9 months ago (2012-03-28 17:37:40 UTC) #2

LGTM

On Wed, Mar 28, 2012 at 10:16 AM, <sadrul@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> ash: New ethernet icon.
>
> BUG=120575
> TEST=none
>
>
> Please review this at
http://codereview.chromium.**org/9791072/<http://codereview.chromium.org/9791...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/app/theme/statusbar_**wired.png
>
>
> Index: chrome/app/theme/statusbar_**wired.png
> diff --git a/chrome/app/theme/statusbar_**wired.png
> b/chrome/app/theme/statusbar_**wired.png
> index 8f084db710f4e55398ce7d4abc3fc8**f745cb451f..**
> 34c96f27d7241e2cc837d4a2e0a6d6**b38b39a45e 100644
> Binary files a/chrome/app/theme/statusbar_**wired.png and
> b/chrome/app/theme/statusbar_**wired.png differ
>
>
>

Expand Messages | Collapse Messages