Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1287)

Unified Diff: media/audio/cross_process_notification_unittest.cc

Issue 9791069: Disable the TwoThreads unit test since it triggers the TSAN bot. This is a false positive since we'… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/cross_process_notification_unittest.cc
diff --git a/media/audio/cross_process_notification_unittest.cc b/media/audio/cross_process_notification_unittest.cc
index 814b527d09662ba6584be4dbcad32612b1bff727..00515a96d67204a6783873d8fbd565d6e4b52bbc 100644
--- a/media/audio/cross_process_notification_unittest.cc
+++ b/media/audio/cross_process_notification_unittest.cc
@@ -218,7 +218,9 @@ TEST(CrossProcessNotification, Basic) {
// Spins two worker threads, each with their own CrossProcessNotification
// that they use to read and write from a shared memory buffer.
-TEST(CrossProcessNotification, TwoThreads) {
+// Disabled as it trips of the TSAN bot (false positive since TSAN doesn't
+// recognize sockets as being a synchronization primitive).
+TEST(CrossProcessNotification, DISABLED_TwoThreads) {
CrossProcessNotification a, b;
ASSERT_TRUE(CrossProcessNotification::InitializePair(&a, &b));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698