Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4466)

Unified Diff: chrome/browser/download/chrome_download_manager_delegate.cc

Issue 9791059: Update comment for SavePackageFilePickerChromeOS irregularity (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/chrome_download_manager_delegate.cc
===================================================================
--- chrome/browser/download/chrome_download_manager_delegate.cc (revision 129387)
+++ chrome/browser/download/chrome_download_manager_delegate.cc (working copy)
@@ -319,7 +319,9 @@
content::SaveFilePathPickedCallback callback) {
// Deletes itself.
#if defined(OS_CHROMEOS)
- // Note that we're ignoring the callback here. TODO(achuith): Fix this.
+ // Note that we're ignoring the callback here.
+ // SavePackageFilePickerChromeOS completes the save operation itself.
+ // TODO(achuith): Fix this.
new SavePackageFilePickerChromeOS(web_contents, suggested_path);
#else
new SavePackageFilePicker(web_contents, suggested_path, default_extension,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698