Revert 129380 - roll rlz 121:122

Revert 129380 - roll rlz 121:122

122: Warning fixes, gyp file cleanup.

BUG=none
TEST=nothing changes
TBR=rogerta

Review URL: http://codereview.chromium.org/9874011

TBR=thakis@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129382

[Nico, 2012-03-28 14:27:16]

A reason would be helpful.
On Mar 27, 2012 11:51 PM, <rsleevi@chromium.org> wrote:

> Reviewers: Nico,
>
> Description:
> Revert 129380 - roll rlz 121:122
>
> 122: Warning fixes, gyp file cleanup.
>
> BUG=none
> TEST=nothing changes
> TBR=rogerta
>
> Review URL:
http://codereview.chromium.**org/9874011<http://codereview.chromium.org/9874011>
>
> TBR=thakis@chromium.org
>
> Please review this at
https://chromiumcodereview.**appspot.com/9791056/<https://chromiumcodereview....
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     DEPS
>
>
> Index: DEPS
> ==============================**==============================**=======
> --- DEPS        (revision 129381)
> +++ DEPS        (working copy)
> @@ -58,7 +58,7 @@
>   "webrtc_revision": "1935",
>   "jsoncpp_revision": "248",
>   "nss_revision": "126189",
> -  "rlz_revision": "122",
> +  "rlz_revision": "121",
>  }
>
>  deps = {
>
>
>

[Ryan Sleevi, 2012-03-28 14:46:34]

http://build.chromium.org/p/chromium/buildstatus?builder=Win%20Builder%202010...

66>win\lib\machine_id_win.cc(67):error C2220: warning treated as error - no
'object' file generated
66>win\lib\machine_id_win.cc(67): warning C4800: 'BOOL' : forcing value to bool
'true' or 'false' (performance warning)

[Nico, 2012-03-28 14:48:15]

On 2012/03/28 14:46:34, Ryan Sleevi wrote:
>
http://build.chromium.org/p/chromium/buildstatus?builder=Win%2520Builder%2520...
> 
> 66>win\lib\machine_id_win.cc(67):error C2220: warning treated as error - no
> 'object' file generated
> 66>win\lib\machine_id_win.cc(67): warning C4800: 'BOOL' : forcing value to
bool
> 'true' or 'false' (performance warning)

Thanks. (Just "broke windows build" is enough, so that I don't have to guess
that that was indeed the reason.)

[Ryan Sleevi, 2012-03-28 18:07:10]

On 2012/03/28 14:48:15, Nico wrote:
> On 2012/03/28 14:46:34, Ryan Sleevi wrote:
> >
>
http://build.chromium.org/p/chromium/buildstatus?builder=Win%252520Builder%25...
> > 
> > 66>win\lib\machine_id_win.cc(67):error C2220: warning treated as error - no
> > 'object' file generated
> > 66>win\lib\machine_id_win.cc(67): warning C4800: 'BOOL' : forcing value to
> bool
> > 'true' or 'false' (performance warning)
> 
> Thanks. (Just "broke windows build" is enough, so that I don't have to guess
> that that was indeed the reason.)

Yeah, I try to do so. I thought I had clicked "Publish Comments" on the above
comment, but alas, I hadn't.