Issue 9791050: Make OncNetworkParserTest use the pre-existing GetCertType implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9791050: Make OncNetworkParserTest use the pre-existing GetCertType implementation. (Closed)

Created:
8 years, 9 months ago by mattm

Modified:
8 years, 8 months ago

Reviewers:
Greg Spencer (Chromium), stevenjb

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make OncNetworkParserTest use the pre-existing GetCertType implementation. BUG=none TEST=try bots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129630

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -8 lines)			Patch
	M	chrome/browser/chromeos/cros/onc_network_parser_unittest.cc	View		2 chunks	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mattm

There are some differences between the two, but the tests still pass with the change. ...

8 years, 9 months ago (2012-03-28 03:17:18 UTC) #1

Greg Spencer (Chromium)

LGTM. There's no reason I know of: perhaps that method didn't exist when I wrote ...

8 years, 9 months ago (2012-03-28 04:04:26 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/9791050/1

8 years, 9 months ago (2012-03-29 00:16:28 UTC) #5

commit-bot: I haz the power

8 years, 9 months ago (2012-03-29 03:31:37 UTC) #6

Try job failure for 9791050-1 (retry) on win_rel for step "browser_tests".
It's a second try, previously, steps "ui_tests, browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages