Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3643)

Unified Diff: build/common.gypi

Issue 9789002: GYP fix: toolkit_uses_gtk% should be dependent on use_aura%. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 61b707045348f517aabcd5d3865848a055d61216..ff971afc7110476c7f4be05e8b7439a1776c5d58 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -325,10 +325,10 @@
}],
# Set toolkit_uses_gtk for the Chromium browser on Linux.
- ['OS=="linux" and chromeos==0', {
- 'toolkit_uses_gtk%': 1,
- }, {
+ ['OS=="linux" and use_aura==1', {
Emmanuel Saint-loubert-Bié 2012/03/20 22:25:15 If you want to go this way the test could simply b
'toolkit_uses_gtk%': 0,
+ }, {
+ 'toolkit_uses_gtk%': 1,
Emmanuel Saint-loubert-Bié 2012/03/20 22:25:15 I am wondering if we should have this set to 1 for
}],
# We always use skia text rendering in Aura on Windows, since GDI
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698