Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 977783002: Add a disabled attribute to the cr-dropdown-menu. (Closed)

Created:
5 years, 9 months ago by Jeremy Klein
Modified:
5 years, 9 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org, oshima+watch_chromium.org, dcheng, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a disabled attribute to the cr-dropdown-menu. BUG= Committed: https://crrev.com/ab44fa6a268e2fb9f0f4362175edabc6a585320a Cr-Commit-Position: refs/heads/master@{#319420}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address a couple style comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.html View 1 chunk +2 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.js View 1 2 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Jeremy Klein
5 years, 9 months ago (2015-03-04 21:12:40 UTC) #2
michaelpg
lgtm I was just curious where the "disabled" attribute was actually published. It comes from ...
5 years, 9 months ago (2015-03-06 03:41:44 UTC) #3
michaelpg
sorry, published the LGTM slightly prematurely -- couple comments. https://codereview.chromium.org/977783002/diff/1/ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.js File ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.js (right): https://codereview.chromium.org/977783002/diff/1/ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.js#newcode1 ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.js:1: ...
5 years, 9 months ago (2015-03-06 03:44:10 UTC) #4
Jeremy Klein
https://codereview.chromium.org/977783002/diff/1/ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.js File ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.js (right): https://codereview.chromium.org/977783002/diff/1/ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.js#newcode1 ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.js:1: /* Copyright 2015 The Chromium Authors. All rights reserved. ...
5 years, 9 months ago (2015-03-06 06:33:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977783002/20001
5 years, 9 months ago (2015-03-06 06:36:07 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-06 07:26:07 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 07:26:48 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab44fa6a268e2fb9f0f4362175edabc6a585320a
Cr-Commit-Position: refs/heads/master@{#319420}

Powered by Google App Engine
This is Rietveld 408576698