Refactor tests that performs an action on the password infobar to identify the infobar by type and …

Refactor tests that performs an action on the password infobar to identify the infobar by type and index of type.

Originally these tests identified the password infobar by the text of the password infobar button.

TEST=none
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128252

[dennis_jeffrey, 2012-03-20 21:17:58]

http://codereview.chromium.org/9775001/diff/1001/chrome/test/functional/passw...
File chrome/test/functional/passwords.py (right):

http://codereview.chromium.org/9775001/diff/1001/chrome/test/functional/passw...
chrome/test/functional/passwords.py:84: def _InfobarTypeDisplayed(self,
infobar_type, windex, tab_index):
Change the function name to something like "_GetInfobarIndexByType"

http://codereview.chromium.org/9775001/diff/1001/chrome/test/functional/passw...
chrome/test/functional/passwords.py:85: """Identifies whether an infobar
displays and get the index.
Returns the index of the infobar of the given type.

http://codereview.chromium.org/9775001/diff/1001/chrome/test/functional/passw...
chrome/test/functional/passwords.py:93: Index of infobar for infobar type, or -1
if not found.
Maybe we should return None in the event it's not found.

http://codereview.chromium.org/9775001/diff/1001/chrome/test/functional/passw...
chrome/test/functional/passwords.py:101: return -1
recommend changing '-1' to 'None'

http://codereview.chromium.org/9775001/diff/1001/chrome/test/functional/passw...
chrome/test/functional/passwords.py:115: self.INFOBAR_TYPE, windex, tab_index)
is not -1),
we can remove 'is not -1' if you address comment at line 101 above.

http://codereview.chromium.org/9775001/diff/1001/chrome/test/functional/passw...
chrome/test/functional/passwords.py:119: return infobar_index
combine the above 2 statements into a single statement

[dyu1, 2012-03-20 22:24:34]

http://codereview.chromium.org/9775001/diff/1001/chrome/test/functional/passw...
File chrome/test/functional/passwords.py (right):

http://codereview.chromium.org/9775001/diff/1001/chrome/test/functional/passw...
chrome/test/functional/passwords.py:84: def _InfobarTypeDisplayed(self,
infobar_type, windex, tab_index):
On 2012/03/20 21:17:58, dennis_jeffrey wrote:
> Change the function name to something like "_GetInfobarIndexByType"

Done.

http://codereview.chromium.org/9775001/diff/1001/chrome/test/functional/passw...
chrome/test/functional/passwords.py:85: """Identifies whether an infobar
displays and get the index.
On 2012/03/20 21:17:58, dennis_jeffrey wrote:
> Returns the index of the infobar of the given type.

Done.

http://codereview.chromium.org/9775001/diff/1001/chrome/test/functional/passw...
chrome/test/functional/passwords.py:93: Index of infobar for infobar type, or -1
if not found.
On 2012/03/20 21:17:58, dennis_jeffrey wrote:
> Maybe we should return None in the event it's not found.

Done.

http://codereview.chromium.org/9775001/diff/1001/chrome/test/functional/passw...
chrome/test/functional/passwords.py:101: return -1
On 2012/03/20 21:17:58, dennis_jeffrey wrote:
> recommend changing '-1' to 'None'

Done.

http://codereview.chromium.org/9775001/diff/1001/chrome/test/functional/passw...
chrome/test/functional/passwords.py:115: self.INFOBAR_TYPE, windex, tab_index)
is not -1),
On 2012/03/20 21:17:58, dennis_jeffrey wrote:
> we can remove 'is not -1' if you address comment at line 101 above.

Done.

http://codereview.chromium.org/9775001/diff/1001/chrome/test/functional/passw...
chrome/test/functional/passwords.py:119: return infobar_index
Done 

On 2012/03/20 21:17:58, dennis_jeffrey wrote:
> combine the above 2 statements into a single statement

[dennis_jeffrey, 2012-03-21 01:00:07]

one nit + one question that came to mind

http://codereview.chromium.org/9775001/diff/9001/chrome/test/functional/passw...
File chrome/test/functional/passwords.py (right):

http://codereview.chromium.org/9775001/diff/9001/chrome/test/functional/passw...
chrome/test/functional/passwords.py:88: infobar_type: The infobar type
displayed.
'displayed' --> 'to look for'

http://codereview.chromium.org/9775001/diff/9001/chrome/test/functional/passw...
chrome/test/functional/passwords.py:119: self.INFOBAR_TYPE, windex, tab_index)
Do we need to return this value?  I just realized that nobody seems to use it. 
If we do need to return it, maybe we should change the function name to reflect
this.

[dyu1, 2012-03-21 01:08:08]

http://codereview.chromium.org/9775001/diff/9001/chrome/test/functional/passw...
File chrome/test/functional/passwords.py (right):

http://codereview.chromium.org/9775001/diff/9001/chrome/test/functional/passw...
chrome/test/functional/passwords.py:88: infobar_type: The infobar type
displayed.
On 2012/03/21 01:00:07, dennis_jeffrey wrote:
> 'displayed' --> 'to look for'

Done.

http://codereview.chromium.org/9775001/diff/9001/chrome/test/functional/passw...
chrome/test/functional/passwords.py:119: self.INFOBAR_TYPE, windex, tab_index)
Yes, since if there are multiple infobars we need to be able to identify the
index of the type of infobar. 

On 2012/03/21 01:00:07, dennis_jeffrey wrote:
> Do we need to return this value?  I just realized that nobody seems to use it.

> If we do need to return it, maybe we should change the function name to
reflect
> this.

[dennis_jeffrey, 2012-03-21 18:09:00]

1 nit and 1 typo fix

http://codereview.chromium.org/9775001/diff/11004/chrome/test/functional/pass...
File chrome/test/functional/passwords.py (right):

http://codereview.chromium.org/9775001/diff/11004/chrome/test/functional/pass...
chrome/test/functional/passwords.py:104: """Return the index and asserts that
the save password infobar appears.
Waits for save password infobar to appear and returns its index.

http://codereview.chromium.org/9775001/diff/11004/chrome/test/functional/pass...
chrome/test/functional/passwords.py:114: self.WaitUntil(lambda:
self._InfobarTypeDisplayed(
_InfobarTypeDisplayed --> _GetInfobarIndexByType

[dyu1, 2012-03-21 18:29:43]

http://codereview.chromium.org/9775001/diff/11004/chrome/test/functional/pass...
File chrome/test/functional/passwords.py (right):

http://codereview.chromium.org/9775001/diff/11004/chrome/test/functional/pass...
chrome/test/functional/passwords.py:104: """Return the index and asserts that
the save password infobar appears.
Done. I wanted to make it generic originally as I was adding it to the test util
file. 

On 2012/03/21 18:09:00, dennis_jeffrey wrote:
> Waits for save password infobar to appear and returns its index.

http://codereview.chromium.org/9775001/diff/11004/chrome/test/functional/pass...
chrome/test/functional/passwords.py:114: self.WaitUntil(lambda:
self._InfobarTypeDisplayed(
On 2012/03/21 18:09:00, dennis_jeffrey wrote:
> _InfobarTypeDisplayed --> _GetInfobarIndexByType

Done.

[dennis_jeffrey, 2012-03-21 18:35:20]

LGTM

Thanks!  I see that the other required CL to add the infobar type information to
Chrome has landed, so this one should be good to go.