Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: frog/leg/emitter.dart

Issue 9773026: Add a method on native classes for is checks. Reduces the code for generating is checks. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | frog/leg/lib/native_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/leg/emitter.dart
===================================================================
--- frog/leg/emitter.dart (revision 5868)
+++ frog/leg/emitter.dart (working copy)
@@ -165,7 +165,7 @@
String arguments = Strings.join(argumentsBuffer, ",");
buffer.add(' return this.${namer.getName(member)}($arguments)');
}
- buffer.add('\n}\n');
+ buffer.add('\n};\n');
}
void addParameterStubs(FunctionElement member,
@@ -318,7 +318,13 @@
}
}
generateTypeTests(classElement, (Element other) {
- buffer.add('${attachTo(namer.operatorIs(other))} = true;\n');
+ buffer.add('${attachTo(namer.operatorIs(other))} = ');
+ if (nativeEmitter.requiresNativeIsCheck(other)) {
+ buffer.add('function() { return true; }');
+ } else {
+ buffer.add('true');
+ }
+ buffer.add(';\n');
});
if (classElement === compiler.objectClass && compiler.enabledNoSuchMethod) {
@@ -335,17 +341,20 @@
if (compiler.universe.isChecks.contains(cls)) {
generateTypeTest(cls);
}
- generateInterfacesIsTests(cls, generateTypeTest);
+ generateInterfacesIsTests(cls, generateTypeTest, new Set<Element>());
}
void generateInterfacesIsTests(ClassElement cls,
- void generateTypeTest(ClassElement element)) {
+ void generateTypeTest(ClassElement element),
+ Set<Element> alreadyGenerated) {
for (Type interfaceType in cls.interfaces) {
Element element = interfaceType.element;
- if (compiler.universe.isChecks.contains(element)) {
+ if (!alreadyGenerated.contains(element) &&
+ compiler.universe.isChecks.contains(element)) {
+ alreadyGenerated.add(element);
generateTypeTest(element);
}
- generateInterfacesIsTests(element, generateTypeTest);
+ generateInterfacesIsTests(element, generateTypeTest, alreadyGenerated);
}
}
« no previous file with comments | « no previous file | frog/leg/lib/native_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698