Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1461)

Unified Diff: runtime/bin/directory.dart

Issue 9773018: Add error handling to directory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/directory.cc ('k') | runtime/bin/directory_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/directory.dart
diff --git a/runtime/bin/directory.dart b/runtime/bin/directory.dart
index 5041837fe83bb8328de3afe7fbb7f81e48696253..3a919c7c994211d3e806db438de8ec373cd7c382 100644
--- a/runtime/bin/directory.dart
+++ b/runtime/bin/directory.dart
@@ -135,7 +135,7 @@ interface Directory default _Directory {
* Sets the handler that is called if there is an error while listing
* or creating directories.
*/
- void set onError(void onError(String error));
+ void set onError(void onError(Exception e));
/**
* Gets the path of this directory.
@@ -146,20 +146,28 @@ interface Directory default _Directory {
class DirectoryIOException implements Exception {
const DirectoryIOException([String this.message = "",
+ String this.path = "",
OSError this.osError = null]);
String toString() {
StringBuffer sb = new StringBuffer();
sb.add("DirectoryIOException");
if (!message.isEmpty()) {
sb.add(": $message");
+ if (path != null) {
+ sb.add(", path = $path");
+ }
if (osError != null) {
sb.add(" ($osError)");
}
} else if (osError != null) {
sb.add(": $osError");
+ if (path != null) {
+ sb.add(", path = $path");
+ }
}
return sb.toString();
}
final String message;
+ final String path;
final OSError osError;
}
« no previous file with comments | « runtime/bin/directory.cc ('k') | runtime/bin/directory_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698