Add error handling to directory

runtime/bin/directory_win.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/directory.h"
 
 #include <errno.h>
 #include <sys/stat.h>
 
 #include "bin/platform.h"
@@ skipping 106 matching lines @@
                      "%s",
                      "\\*");
   if (written != 2) {
     return false;
   }
   *path_length += written;
   return true;
 }
 
 static void PostError(DirectoryListing* listing,
-                      const char* prefix,
-                      const char* suffix) {
-  char* error_str = Platform::StrError(GetLastError());
-  int error_message_size =
-      strlen(prefix) + strlen(suffix) + strlen(error_str) + 3;
-  char* message = static_cast<char*>(malloc(error_message_size + 1));
-  size_t written = snprintf(message,
-                            error_message_size + 1,
-                            "%s%s (%s)",
-                            prefix,
-                            suffix,
-                            error_str);
-  ASSERT(written == error_message_size);
-  free(error_str);
-  listing->HandleError(message);
-  free(message);
+                      const char* dir_name) {
+  listing->HandleError(dir_name);
 }
 
 
 static bool ListRecursively(const char* dir_name,
                             bool recursive,
                             DirectoryListing* listing) {
   // Compute full path for the directory currently being listed.  The
   // path buffer will be used to construct the current path in the
   // recursive traversal. path_length does not always equal
   // strlen(path) but indicates the current prefix of path that is the
   // path of the current directory in the traversal.
   char* path = static_cast<char*>(malloc(MAX_PATH));
   int path_length = 0;
   bool valid = ComputeFullSearchPath(dir_name, path, &path_length);
   if (!valid) {
-    PostError(listing, "Directory listing failed for: ", dir_name);
+    PostError(listing, dir_name);
     free(path);
     return false;
   }
 
   WIN32_FIND_DATA find_file_data;
   HANDLE find_handle = FindFirstFile(path, &find_file_data);
 
   // Adjust the path by removing the '*' used for the search.
   path_length -= 1;
   path[path_length] = '\0';
 
   if (find_handle == INVALID_HANDLE_VALUE) {
-    PostError(listing, "Directory listing failed for: ", path);
+    PostError(listing, path);
     free(path);
     return false;
   }
 
   bool success = HandleEntry(&find_file_data,
                              path,
                              path_length,
                              recursive,
                              listing);
 
   while ((FindNextFile(find_handle, &find_file_data) != 0) && success) {
     success = success && HandleEntry(&find_file_data,
                                      path,
                                      path_length,
                                      recursive,
                                      listing);
   }
 
   if (GetLastError() != ERROR_NO_MORE_FILES) {
     success = false;
-    PostError(listing, "Directory listing failed", "");
+    PostError(listing, dir_name);
   }
 
   if (FindClose(find_handle) == 0) {
-    PostError(listing, "Failed to close directory", "");
+    success = false;
+    PostError(listing, dir_name);
   }
   free(path);
 
   return success;
 }
 
 
 static bool DeleteFile(char* file_name,
                        char* path,
                        int path_length) {
@@ skipping 181 matching lines @@
 }
 
 
 bool Directory::Delete(const char* dir_name, bool recursive) {
   if (!recursive) {
     return (RemoveDirectory(dir_name) != 0);
   } else {
     return DeleteRecursively(dir_name);
   }
 }