Add error handling to directory

runtime/bin/directory_posix.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/directory.h"
 
 #include <dirent.h>
 #include <errno.h>
 #include <sys/param.h>
 #include <sys/stat.h>
@@ skipping 75 matching lines @@
                             "%s",
                             file_name);
   if (written != strlen(file_name)) {
     return false;
   }
   return listing->HandleFile(path);
 }
 
 
 static void PostError(DirectoryListing *listing,
-                      const char* prefix,
-                      const char* suffix,
-                      int error_code) {
-  // TODO(sgjesse): Pass flags to indicate whether error response is
-  // needed.
-  char* error_str = Platform::StrError(error_code);
-  int error_message_size =
-      strlen(prefix) + strlen(suffix) + strlen(error_str) + 3;
-  char* message = static_cast<char*>(malloc(error_message_size + 1));
-  int written = snprintf(message,
-                         error_message_size + 1,
-                         "%s%s (%s)",
-                         prefix,
-                         suffix,
-                         error_str);
-  ASSERT(written == error_message_size);
-  free(error_str);
-  listing->HandleError(message);
-  free(message);
+                      const char* dir_name) {
+  listing->HandleError(dir_name);
 }
 
 
 static bool ListRecursively(const char* dir_name,
                             bool recursive,
                             DirectoryListing *listing) {
   DIR* dir_pointer;
   do {
     dir_pointer = opendir(dir_name);
   } while (dir_pointer == NULL && errno == EINTR);
   if (dir_pointer == NULL) {
-    PostError(listing, "Directory listing failed for: ", dir_name, errno);
+    PostError(listing, dir_name);
     return false;
   }
 
   // Compute full path for the directory currently being listed.  The
   // path buffer will be used to construct the current path in the
   // recursive traversal. path_length does not always equal
   // strlen(path) but indicates the current prefix of path that is the
   // path of the current directory in the traversal.
   char *path = static_cast<char*>(malloc(PATH_MAX));
   ASSERT(path != NULL);
   int path_length = 0;
   bool valid = ComputeFullPath(dir_name, path, &path_length);
   if (!valid) {
     free(path);
-    PostError(listing, "Directory listing failed for: ", dir_name, errno);
+    PostError(listing, dir_name);
     return false;
   }
 
   // Iterated the directory and post the directories and files to the
   // ports.
   int read = 0;
   bool success = true;
   dirent entry;
   dirent* result;
   while ((read = TEMP_FAILURE_RETRY(readdir_r(dir_pointer,
@@ skipping 24 matching lines @@
                                   PATH_MAX - path_length,
                                   "%s",
                                   entry.d_name);
         if (written != strlen(entry.d_name)) {
           success = false;
           break;
         }
         int lstat_success = TEMP_FAILURE_RETRY(lstat(path, &entry_info));
         if (lstat_success == -1) {
           success = false;
-          PostError(listing, "Directory listing failed for: ", path, errno);
+          PostError(listing, path);
           break;
         }
         if ((entry_info.st_mode & S_IFMT) == S_IFDIR) {
           success = success && HandleDir(entry.d_name,
                                          path,
                                          path_length,
                                          recursive,
                                          listing);
         } else if ((entry_info.st_mode & S_IFMT) == S_IFREG) {
           success = success && HandleFile(entry.d_name,
                                           path,
                                           path_length,
                                           listing);
         }
         break;
       }
       default:
         break;
     }
   }
 
   if (read != 0) {
+    errno = read;
     success = false;
-    PostError(listing, "Directory listing failed", "", read);
+    PostError(listing, dir_name);
   }
 
   if (closedir(dir_pointer) == -1) {
-    PostError(listing, "Failed to close directory", "", errno);
+    success = false;
+    PostError(listing, dir_name);
   }
   free(path);
 
   return success;
 }
 
 
 static bool DeleteFile(char* file_name,
                        char* path,
                        int path_length) {
@@ skipping 187 matching lines @@
 }
 
 
 bool Directory::Delete(const char* dir_name, bool recursive) {
   if (!recursive) {
     return (TEMP_FAILURE_RETRY(remove(dir_name)) == 0);
   } else {
     return DeleteRecursively(dir_name);
   }
 }