Issue 9764013: Move authorization_util files into base/mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9764013: Move authorization_util files into base/mac. (Closed)

Created:
8 years, 9 months ago by Lambros

Modified:
8 years, 9 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Move authorization_util files into base/mac. No logical code changes in this CL. This moves some Mac utilities from chrome/browser/mac to base/mac, so they can be used by the Remoting Host plugin code in remoting/host/plugin BUG=None TEST=Compiles, unit_tests run Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128053

Patch Set 1 #

Patch Set 2 : Fix license headers #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -368 lines)			Patch
M	base/base.gypi	View		2 chunks	+3 lines, -0 lines	0 comments	Download
A +	base/mac/authorization_util.h	View	1	3 chunks	+8 lines, -6 lines	0 comments	Download
A +	base/mac/authorization_util.mm	View		3 chunks	+6 lines, -4 lines	0 comments	Download
A +	base/mac/scoped_authorizationref.h	View	1	3 chunks	+10 lines, -4 lines	0 comments	Download
D	chrome/browser/mac/authorization_util.h	View		1 chunk	+0 lines, -67 lines	0 comments	Download
D	chrome/browser/mac/authorization_util.mm	View		1 chunk	+0 lines, -185 lines	0 comments	Download
M	chrome/browser/mac/install_from_dmg.mm	View		5 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/mac/keystone_glue.h	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/mac/keystone_glue.mm	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/mac/keystone_promote_postflight.sh	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/mac/keystone_promote_preflight.sh	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/mac/scoped_authorizationref.h	View		1 chunk	+0 lines, -80 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/9764013/1

8 years, 9 months ago (2012-03-21 20:27:03 UTC) #3

commit-bot: I haz the power

8 years, 9 months ago (2012-03-21 20:27:12 UTC) #4

Presubmit check for 9764013-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  base/mac/authorization_util.h, line 24, 124 chars

Presubmit checks took 1.1s to calculate.

Expand Messages | Collapse Messages