Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: ash/shell_unittest.cc

Issue 9764008: Makes the launcher auto-hide for maximized windows. This turned out to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add null checks and cleanup Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shell_unittest.cc
diff --git a/ash/shell_unittest.cc b/ash/shell_unittest.cc
index 7777ef0c472752008a1ae6165db33ce063b93506..9f5ff3ae02ff1effe3aa5ff3893e8d613c76444d 100644
--- a/ash/shell_unittest.cc
+++ b/ash/shell_unittest.cc
@@ -336,15 +336,18 @@ TEST_F(ShellTest, FullscreenWindowHidesShelf) {
EXPECT_FALSE(widget->IsMaximized());
// Shelf defaults to visible.
- EXPECT_TRUE(Shell::GetInstance()->shelf()->visible());
+ EXPECT_EQ(internal::ShelfLayoutManager::VISIBLE,
+ Shell::GetInstance()->shelf()->visibility_state());
// Fullscreen window hides it.
widget->SetFullscreen(true);
- EXPECT_FALSE(Shell::GetInstance()->shelf()->visible());
+ EXPECT_EQ(internal::ShelfLayoutManager::HIDDEN,
+ Shell::GetInstance()->shelf()->visibility_state());
// Restoring the window restores it.
widget->Restore();
- EXPECT_TRUE(Shell::GetInstance()->shelf()->visible());
+ EXPECT_EQ(internal::ShelfLayoutManager::VISIBLE,
+ Shell::GetInstance()->shelf()->visibility_state());
// Clean up.
widget->Close();
« ash/launcher/launcher.cc ('K') | « ash/shell.cc ('k') | ash/wm/base_layout_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698