Gesture recognition constants should all be stored in the GestureConfiguration object.

ui/aura/test/aura_test_base.cc

Index: ui/aura/test/aura_test_base.cc
diff --git a/ui/aura/test/aura_test_base.cc b/ui/aura/test/aura_test_base.cc
index 592c780f45bb17bfd7c1048cc94f89c842d237d2..25e0874d63a210d0c600a35c00ba3b9790c755e4 100644
--- a/ui/aura/test/aura_test_base.cc
+++ b/ui/aura/test/aura_test_base.cc
@@ -5,6 +5,7 @@
 #include "ui/aura/test/aura_test_base.h"
 
 #include "ui/aura/env.h"
+#include "ui/aura/gestures/gesture_configuration.h"
 #include "ui/aura/monitor_manager.h"
 #include "ui/aura/single_monitor_manager.h"
 #include "ui/aura/root_window.h"
@@ -24,6 +25,24 @@ AuraTestBase::~AuraTestBase() {
 
 void AuraTestBase::SetUp() {
   testing::Test::SetUp();
+
+  // Changing the parameters for gesture recognition shouldn't cause

[girard, 2012/03/20 18:30:59]

Is this necessary? Are the configured parameters used in these unit tests?
Maybe we could modify the specific unit tests to set these as needed, or modify
their logic to use the current value?

[tdresser, 2012/03/20 19:34:10]

It seems beneficial to isolate changes to GestureConfiguration as much as
possible. Although this may be overkill, it guarantees that changes to
GestureConfiguration will never break unit tests.

It would be easy for a future unit test author to forget to specify all relevant
attributes of GestureConfiguration, causing future modifications to
GestureConfiguration to break unit tests.

+  // tests to fail, so we use a separate set of parameters for unit
+  // testing.
+  GestureConfiguration::set_long_press_time_in_ms(500);
+  GestureConfiguration::set_max_seconds_between_double_click(0.7);
+  GestureConfiguration::set_max_touch_down_duration_in_seconds_for_click(0.8);
+  GestureConfiguration::set_max_touch_move_in_pixels_for_click(20);
+  GestureConfiguration::set_min_distance_for_pinch_scroll_in_pixels(20);
+  GestureConfiguration::set_min_flick_speed_squared(550.f * 550.f);
+  GestureConfiguration::set_min_pinch_update_distance_in_pixels(5);
+  GestureConfiguration::set_min_rail_break_velocity(200);
+  GestureConfiguration::set_min_scroll_delta_squared(5 * 5);
+  GestureConfiguration::set_min_touch_down_duration_in_seconds_for_click(0.01);
+  GestureConfiguration::set_points_buffered_for_velocity(10);
+  GestureConfiguration::set_rail_break_proportion(15);
+  GestureConfiguration::set_rail_start_proportion(2);
+
   root_window_.reset(Env::GetInstance()->monitor_manager()->
                      CreateRootWindowForPrimaryMonitor());
   gfx::Screen::SetInstance(new aura::TestScreen(root_window_.get()));