Issue 9750007: Use correct arguments adaptation environment when inlining function containing arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9750007: Use correct arguments adaptation environment when inlining function containing arguments. (Closed)

Created:
8 years, 9 months ago by Vyacheslav Egorov (Chromium)

Modified:
8 years, 9 months ago

Reviewers:
Michael Starzinger (Google), Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use correct arguments adaptation environment when inlining function containing arguments. R=mstarzinger@google.com BUG=v8:2014 TEST=test/mjsunit/compile/inline-arguments.js Committed: https://code.google.com/p/v8/source/detail?r=11098

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -13 lines)			Patch
M	src/hydrogen.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+4 lines, -13 lines	0 comments	Download
M	test/mjsunit/compiler/inline-arguments.js	View	1 chunk	+32 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 9 months ago (2012-03-20 17:48:41 UTC) #2

LGTM (with a nit).

https://chromiumcodereview.appspot.com/9750007/diff/1/test/mjsunit/compiler/i...
File test/mjsunit/compiler/inline-arguments.js (right):

https://chromiumcodereview.appspot.com/9750007/diff/1/test/mjsunit/compiler/i...
test/mjsunit/compiler/inline-arguments.js:87: "use strict";  // Strict mode
prevents arguments object from shadowing parameters.
Line is longer than 80 characters.

Expand Messages | Collapse Messages