Write "http://disney.com" to the clipboard when copying URLs in incognito mode.

Write "http://disney.com" to the clipboard when copying URLs in incognito mode.

BUG=none
TEST=Send email to chromium-dev about a build breakage.
"sample build output here" link points to disney.com.

[KushalP, 2012-03-20 11:17:29]

On 2012/03/20 06:12:48, Nico wrote:

LGTM

Please get this important CL merged into the tree!

[mathias, 2012-03-20 12:21:21]

The trailing slash is missing: http://disney.com/

[Avi (use Gerrit), 2012-03-20 15:14:29]

https://chromiumcodereview.appspot.com/9750002/diff/1/chrome/browser/autocomp...
File chrome/browser/autocomplete/autocomplete_edit.cc (right):

https://chromiumcodereview.appspot.com/9750002/diff/1/chrome/browser/autocomp...
chrome/browser/autocomplete/autocomplete_edit.cc:361: bool is_incognito =
profile_->GetOriginalProfile() != profile_;
This is the wrong way to do it.

bool is_incognito = profile_->IsOffTheRecord();

Don't forget that a Profile is a BrowserContext.

[Nico, 2012-03-20 15:24:49]

mathias: For the url pasteboard flavor, GURL knows how to add the /. For the
text pasteboard flavor, trailing /s look ugly, so I figured I'd leave it out
even if it's technically less correct.

https://chromiumcodereview.appspot.com/9750002/diff/1/chrome/browser/autocomp...
File chrome/browser/autocomplete/autocomplete_edit.cc (right):

https://chromiumcodereview.appspot.com/9750002/diff/1/chrome/browser/autocomp...
chrome/browser/autocomplete/autocomplete_edit.cc:361: bool is_incognito =
profile_->GetOriginalProfile() != profile_;
On 2012/03/20 15:14:30, Avi wrote:
> This is the wrong way to do it.
> 
> bool is_incognito = profile_->IsOffTheRecord();
> 
> Don't forget that a Profile is a BrowserContext.

Done.