Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 974803002: Defer addStubs to class instantiation time. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Ensure fast prototypes and avoid polymorphic access in constructor Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index 75f3dab49e198e7a3d9bf2656793766d72e2e1c4..072517a1cc733f4d98b9f8add84c6e0f80a787db 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -555,7 +555,7 @@ class JavaScriptBackend extends Backend {
* Record that [method] is called from a subclass via `super`.
*/
bool maybeRegisterAliasedSuperMember(Element member, Selector selector) {
- if (selector.isGetter || compiler.hasIncrementalSupport) {
+ if (!canUseAliasedSuperMember(member, selector)) {
// Invoking a super getter isn't supported, this would require changes to
// compact field descriptors in the emitter.
// We also turn off this optimization in incremental compilation, to
@@ -567,6 +567,10 @@ class JavaScriptBackend extends Backend {
return true;
}
+ bool canUseAliasedSuperMember(Element member, Selector selector) {
+ return !selector.isGetter && !compiler.hasIncrementalSupport;
+ }
+
/**
* Returns `true` if [member] is called from a subclass via `super`.
*/
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/namer.dart » ('j') | pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698