Issue 9748007: HeapProfiler doesn't track array movements when it is shifting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9748007: HeapProfiler doesn't track array movements when it is shifting. (Closed)

Created:
8 years, 9 months ago by loislo

Modified:
8 years, 9 months ago

Reviewers:
mnaganov (inactive)

CC:
yurys, alexeif, Vyacheslav Egorov (Chromium)

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

There is a trick for speed up array shift operation. This trick is confusing a bit the heap snapshoting code. Such a shiffted array will be interpreted as a new array in the second snapshot. BUG=none TEST=HeapEntryIdsAndArrayShift

Patch Set 1 #

Patch Set 2 : A test was added #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -0 lines)			Patch
	M	src/builtins.cc	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
	M	test/cctest/test-heap-profiler.cc	View	1	1 chunk	+53 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages