kiosk: Ensure launching latest version.

chrome/browser/extensions/external_provider_impl.cc

Index: chrome/browser/extensions/external_provider_impl.cc
diff --git a/chrome/browser/extensions/external_provider_impl.cc b/chrome/browser/extensions/external_provider_impl.cc
index 9966755d07db3e8aa3612060925a8829c2b03ed6..74152e8c21dc79b4f929ee124e6244564ef8daa9 100644
--- a/chrome/browser/extensions/external_provider_impl.cc
+++ b/chrome/browser/extensions/external_provider_impl.cc
@@ -423,13 +423,14 @@ void ExternalProviderImpl::CreateExternalProviders(
         chromeos::KioskAppManager::Get();
     DCHECK(kiosk_app_manager);
     if (kiosk_app_manager && !kiosk_app_manager->external_loader_created()) {
-      provider_list->push_back(linked_ptr<ExternalProviderInterface>(
-          new ExternalProviderImpl(service,
-                                   kiosk_app_manager->CreateExternalLoader(),
-                                   profile,
-                                   Manifest::EXTERNAL_PREF,
-                                   Manifest::INVALID_LOCATION,
-                                   Extension::NO_FLAGS)));
+      scoped_ptr<ExternalProviderImpl> kiosk_app_provider(
+          new ExternalProviderImpl(
+              service, kiosk_app_manager->CreateExternalLoader(), profile,
+              Manifest::EXTERNAL_PREF, Manifest::INVALID_LOCATION,
+              Extension::NO_FLAGS));

[Yoyo Zhou, 2015/03/03 21:38:23]

I think you should just set the kInstallFlagInstallImmediately flag - no need to
manually call into the install-immediately flow for ExtensionService.

[xiyuan, 2015/03/03 22:04:21]

To do that, it seems we need to add a boolean member to ExternalProviderImpl and
plumb it through OnExternalExtensionFileFound so that the CrxInstaller gets it.

Is there a better way?

[xiyuan, 2015/03/03 22:33:20]

Done. Let me know what you think.

+      kiosk_app_provider->set_auto_acknowledge(true);
+      provider_list->push_back(
+          linked_ptr<ExternalProviderInterface>(kiosk_app_provider.release()));
     }
 #endif
     return;