Adding file access permissions to fileBrowserHandler manifest.

chrome/common/extensions/extension_manifests_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #if defined(TOOLKIT_GTK)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 965 matching lines @@
 
   CommandLine::ForCurrentProcess()->AppendSwitch(
       switches::kEnableExperimentalExtensionApis);
   scoped_refptr<Extension> extension2(
       LoadAndExpectSuccess("isolated_app_valid.json"));
   EXPECT_TRUE(extension2->is_storage_isolated());
 }
 
 
 TEST_F(ExtensionManifestTest, FileBrowserHandlers) {
+  LoadAndExpectError("filebrowser_invalid_access_permission.json",
+      ExtensionErrorUtils::FormatErrorMessage(
+          errors::kInvalidFileAccessValue, base::IntToString(1)));
+  LoadAndExpectError("filebrowser_invalid_access_permission_list.json",
+      errors::kInvalidFileAccessList);
+  LoadAndExpectError("filebrowser_invalid_empty_access_permission_list.json",
+      errors::kInvalidFileAccessList);
   LoadAndExpectError("filebrowser_invalid_actions_1.json",
       errors::kInvalidFileBrowserHandler);
   LoadAndExpectError("filebrowser_invalid_actions_2.json",
       errors::kInvalidFileBrowserHandler);
   LoadAndExpectError("filebrowser_invalid_action_id.json",
       errors::kInvalidPageActionId);
   LoadAndExpectError("filebrowser_invalid_action_title.json",
       errors::kInvalidPageActionDefaultTitle);
   LoadAndExpectError("filebrowser_invalid_action_id.json",
       errors::kInvalidPageActionId);
@@ skipping 11 matching lines @@
   ASSERT_TRUE(extension->file_browser_handlers() != NULL);
   ASSERT_EQ(extension->file_browser_handlers()->size(), 1U);
   const FileBrowserHandler* action =
       extension->file_browser_handlers()->at(0).get();
   EXPECT_EQ(action->title(), "Default title");
   EXPECT_EQ(action->icon_path(), "icon.png");
   const URLPatternSet& patterns = action->file_url_patterns();
   ASSERT_EQ(patterns.patterns().size(), 1U);
   ASSERT_TRUE(action->MatchesURL(
       GURL("filesystem:chrome-extension://foo/local/test.txt")));
+  ASSERT_FALSE(action->HasCreateAccessPermission());
+  ASSERT_TRUE(action->CanRead());
+  ASSERT_TRUE(action->CanWrite());
+
+  scoped_refptr<Extension> create_extension(
+      LoadAndExpectSuccess("filebrowser_valid_with_create.json"));
+  ASSERT_TRUE(create_extension->file_browser_handlers() != NULL);
+  ASSERT_EQ(create_extension->file_browser_handlers()->size(), 1U);
+  const FileBrowserHandler* create_action =
+      create_extension->file_browser_handlers()->at(0).get();
+  EXPECT_EQ(create_action->title(), "Default title");
+  EXPECT_EQ(create_action->icon_path(), "icon.png");
+  const URLPatternSet& create_patterns = create_action->file_url_patterns();
+  ASSERT_EQ(create_patterns.patterns().size(), 0U);
+  ASSERT_TRUE(create_action->HasCreateAccessPermission());
+  ASSERT_FALSE(create_action->CanRead());
+  ASSERT_FALSE(create_action->CanWrite());
 }
 
 TEST_F(ExtensionManifestTest, FileManagerURLOverride) {
   // A component extention can override chrome://files/ URL.
   std::string error;
   scoped_refptr<Extension> extension;
   extension = LoadExtension(
       Manifest("filebrowser_url_override.json"),
       &error,
       Extension::COMPONENT,
@@ skipping 130 matching lines @@
   // Extension with manifest version 2 *can* use storage API.
   {
     DictionaryValue manifest_with_version;
     manifest_with_version.SetInteger(keys::kManifestVersion, 2);
     manifest_with_version.MergeDictionary(&base_manifest);
 
     Manifest manifest(&manifest_with_version, "test");
     LoadAndExpectSuccess(manifest);
   }
 }