Adding file access permissions to fileBrowserHandler manifest.

chrome/common/extensions/file_browser_handler.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_FILE_BROWSER_HANDLER_H_
 #define CHROME_COMMON_EXTENSIONS_FILE_BROWSER_HANDLER_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 32 matching lines @@
   void AddPattern(const URLPattern& pattern);
   bool MatchesURL(const GURL& url) const;
   void ClearPatterns();
 
   // Action icon path.
   const std::string icon_path() const { return default_icon_path_; }
   void set_icon_path(const std::string& path) {
     default_icon_path_ = path;
   }
 
+  // File access permissions.
+  bool AddFileAccessPermission(const std::string& permission_str);

[Yoyo Zhou, 2012/03/26 22:42:58]

Both these functions should have some documentation here: at the very least,
what they return.

[tbarzic, 2012/03/26 23:22:51]

Done.

+  bool InvalidateFileAccessPermissions();

[Yoyo Zhou, 2012/03/26 22:42:58]

I think it'd be clearer if it was called ValidateFileAccessPermissions.

[tbarzic, 2012/03/26 23:22:51]

Done.

+  bool CanRead() const;
+  bool CanWrite() const;
+  bool CanCreate() const;
+
  private:
   // The id for the extension this action belongs to (as defined in the
   // extension manifest).
   std::string extension_id_;
   std::string title_;
   std::string default_icon_path_;
   // The id for the FileBrowserHandler, for example: "PdfFileAction".
   std::string id_;
+  unsigned int file_access_permission_flags_;
+
   // A list of file filters.
   URLPatternSet url_set_;
 };
 
 #endif  // CHROME_COMMON_EXTENSIONS_FILE_BROWSER_HANDLER_H_